You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/08/31 11:37:27 UTC
[GitHub] [incubator-kyuubi] zhouyifan279 opened a new pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
zhouyifan279 opened a new pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Executing test case "ServiceDiscoverySuite @set up zookeeper auth" on a Linux host named "KYUUBI" fails.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909198791
late lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909196696
Thanks, merging to master/1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] zhouyifan279 commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
zhouyifan279 commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909193585
@ulysses-you @yaooqinn @pan3793, could you take a review, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909195747
Thanks for the PR, this should also fix the failure on WSL2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909198791
late lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909198791
late lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] zhouyifan279 commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
zhouyifan279 commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909193585
@ulysses-you @yaooqinn @pan3793, could you take a review, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909173145
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1006](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (045c6b3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b382ed0dd87e9e19cab40f3e6b596c042ecdc066?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b382ed0) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1006 +/- ##
============================================
+ Coverage 80.06% 80.08% +0.01%
Complexity 11 11
============================================
Files 152 152
Lines 5553 5553
Branches 644 644
============================================
+ Hits 4446 4447 +1
+ Misses 725 723 -2
- Partials 382 383 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `46.34% <0.00%> (+0.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b382ed0...045c6b3](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909195747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909173145
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1006](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (045c6b3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b382ed0dd87e9e19cab40f3e6b596c042ecdc066?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b382ed0) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1006 +/- ##
============================================
+ Coverage 80.06% 80.08% +0.01%
Complexity 11 11
============================================
Files 152 152
Lines 5553 5553
Branches 644 644
============================================
+ Hits 4446 4447 +1
+ Misses 725 723 -2
- Partials 382 383 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `46.34% <0.00%> (+0.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b382ed0...045c6b3](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909195747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909173145
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1006](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (045c6b3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b382ed0dd87e9e19cab40f3e6b596c042ecdc066?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b382ed0) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1006 +/- ##
============================================
+ Coverage 80.06% 80.08% +0.01%
Complexity 11 11
============================================
Files 152 152
Lines 5553 5553
Branches 644 644
============================================
+ Hits 4446 4447 +1
+ Misses 725 723 -2
- Partials 382 383 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `46.34% <0.00%> (+0.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b382ed0...045c6b3](https://codecov.io/gh/apache/incubator-kyuubi/pull/1006?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] zhouyifan279 commented on pull request #1006: [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter
Posted by GitBox <gi...@apache.org>.
zhouyifan279 commented on pull request #1006:
URL: https://github.com/apache/incubator-kyuubi/pull/1006#issuecomment-909193585
@ulysses-you @yaooqinn @pan3793, could you take a review, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org