You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bu...@apache.org on 2020/06/03 21:59:37 UTC

[geode-benchmarks] branch sni updated: eliminate timeout specs from HAproxy config (so they are infinite)

This is an automated email from the ASF dual-hosted git repository.

burcham pushed a commit to branch sni
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git


The following commit(s) were added to refs/heads/sni by this push:
     new 66eda04  eliminate timeout specs from HAproxy config (so they are infinite)
66eda04 is described below

commit 66eda044af7139981df2a626f7cf327d46e32e3e
Author: Bill Burcham <bb...@pivotal.io>
AuthorDate: Wed Jun 3 14:59:25 2020 -0700

    eliminate timeout specs from HAproxy config (so they are infinite)
---
 .../java/org/apache/geode/benchmark/tasks/StartSniProxy.java   | 10 +++++++---
 .../org/apache/geode/benchmark/tasks/StartSniProxyTest.java    | 10 +++++++---
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/StartSniProxy.java b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/StartSniProxy.java
index 296d8d9..c974585 100644
--- a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/StartSniProxy.java
+++ b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/StartSniProxy.java
@@ -104,9 +104,13 @@ public class StartSniProxy implements Task {
         + "  log stdout format raw local0 debug\n"
         + "defaults\n"
         + "  log global\n"
-        + "  timeout client 100s\n"
-        + "  timeout connect 100s\n"
-        + "  timeout server 100s\n"
+        /*
+         We're leaving timeouts unspecified so they are infinite. Benchmarks do bad things
+         when the proxy breaks connections.
+        */
+//        + "  timeout client 100s\n"
+//        + "  timeout connect 100s\n"
+//        + "  timeout server 100s\n"
         + "frontend sniproxy\n"
         + "  bind *:15443\n"
         + "  mode tcp\n"
diff --git a/geode-benchmarks/src/test/java/org/apache/geode/benchmark/tasks/StartSniProxyTest.java b/geode-benchmarks/src/test/java/org/apache/geode/benchmark/tasks/StartSniProxyTest.java
index 00ffe9a..ea73c46 100644
--- a/geode-benchmarks/src/test/java/org/apache/geode/benchmark/tasks/StartSniProxyTest.java
+++ b/geode-benchmarks/src/test/java/org/apache/geode/benchmark/tasks/StartSniProxyTest.java
@@ -35,9 +35,13 @@ class StartSniProxyTest {
         + "  log stdout format raw local0 debug\n"
         + "defaults\n"
         + "  log global\n"
-        + "  timeout client 100s\n"
-        + "  timeout connect 100s\n"
-        + "  timeout server 100s\n"
+        /*
+         We're leaving timeouts unspecified so they are infinite. Benchmarks do bad things
+         when the proxy breaks connections.
+        */
+//        + "  timeout client 100s\n"
+//        + "  timeout connect 100s\n"
+//        + "  timeout server 100s\n"
         + "frontend sniproxy\n"
         + "  bind *:15443\n"
         + "  mode tcp\n"