You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Trejkaz (Created) (JIRA)" <ji...@apache.org> on 2011/11/06 22:47:51 UTC

[jira] [Created] (LUCENE-3565) StandardQueryParser generates incorrect query for groups containing one term if using default operator AND

StandardQueryParser generates incorrect query for groups containing one term if using default operator AND
----------------------------------------------------------------------------------------------------------

                 Key: LUCENE-3565
                 URL: https://issues.apache.org/jira/browse/LUCENE-3565
             Project: Lucene - Java
          Issue Type: Bug
          Components: modules/queryparser
    Affects Versions: 3.4
            Reporter: Trejkaz


The following test demonstrates a bug in StandardQueryParser when DEFAULT_OPERATOR is set to AND:

{code}
    @Test
    public void testDefaultOperatorSingleGrouped() throws Exception
    {
        StandardQueryParser parser = new StandardQueryParser();
        parser.getQueryConfigHandler().set(StandardQueryConfigHandler.ConfigurationKeys.DEFAULT_OPERATOR, StandardQueryConfigHandler.Operator.AND);

        BooleanQuery expectedQuery = new BooleanQuery();
        BooleanQuery innerQuery1 = new BooleanQuery();
        innerQuery1.add(new TermQuery(new Term("text", "a")), BooleanClause.Occur.MUST);
        expectedQuery.add(innerQuery1, BooleanClause.Occur.SHOULD);
        BooleanQuery innerQuery2 = new BooleanQuery();
        innerQuery2.add(new TermQuery(new Term("text", "b")), BooleanClause.Occur.MUST);
        expectedQuery.add(innerQuery2, BooleanClause.Occur.SHOULD);
        Query actualQuery = parser.parse("(a) OR (b)", "text");

        assertEquals("Wrong query was generated", expectedQuery, actualQuery);
    }
{code}

BooleanSingleChildOptimizationQueryNodeProcessor appears to be responsible because if I remove it, the correct query is generated (however, doing so breaks a number of other tests of our own.)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

[jira] [Commented] (LUCENE-3565) StandardQueryParser generates incorrect query for groups containing one term if using default operator AND

Posted by "Trejkaz (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145125#comment-13145125 ] 

Trejkaz commented on LUCENE-3565:
---------------------------------

I guess another valid result of parsing this query could be:

{code}
        BooleanQuery expectedQuery = new BooleanQuery();
        expectedQuery.add(new TermQuery(new Term("text", "a")), BooleanClause.Occur.SHOULD);
        expectedQuery.add(new TermQuery(new Term("text", "b")), BooleanClause.Occur.SHOULD);
{code}

Which would still keep the spirit of removing single-child boolean queries.

What is actually generated, however, is the same query with MUST for both clauses.

                
> StandardQueryParser generates incorrect query for groups containing one term if using default operator AND
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3565
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3565
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/queryparser
>    Affects Versions: 3.4
>            Reporter: Trejkaz
>              Labels: queryparser
>
> The following test demonstrates a bug in StandardQueryParser when DEFAULT_OPERATOR is set to AND:
> {code}
>     @Test
>     public void testDefaultOperatorSingleGrouped() throws Exception
>     {
>         StandardQueryParser parser = new StandardQueryParser();
>         parser.getQueryConfigHandler().set(StandardQueryConfigHandler.ConfigurationKeys.DEFAULT_OPERATOR, StandardQueryConfigHandler.Operator.AND);
>         BooleanQuery expectedQuery = new BooleanQuery();
>         BooleanQuery innerQuery1 = new BooleanQuery();
>         innerQuery1.add(new TermQuery(new Term("text", "a")), BooleanClause.Occur.MUST);
>         expectedQuery.add(innerQuery1, BooleanClause.Occur.SHOULD);
>         BooleanQuery innerQuery2 = new BooleanQuery();
>         innerQuery2.add(new TermQuery(new Term("text", "b")), BooleanClause.Occur.MUST);
>         expectedQuery.add(innerQuery2, BooleanClause.Occur.SHOULD);
>         Query actualQuery = parser.parse("(a) OR (b)", "text");
>         assertEquals("Wrong query was generated", expectedQuery, actualQuery);
>     }
> {code}
> BooleanSingleChildOptimizationQueryNodeProcessor appears to be responsible because if I remove it, the correct query is generated (however, doing so breaks a number of other tests of our own.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org