[GitHub] [cloudstack] SadiJr edited a comment on pull request #5457: Block remove of VM which has backup offering

[GitBox <gi...@apache.org>]

SadiJr edited a comment on pull request #5457:
URL: https://github.com/apache/cloudstack/pull/5457#issuecomment-921912197


   @RodrigoDLopez 
   Thanks for the suggestion, it's a great one.
   
   @DaanHoogland @rhtyd 
   
   Thanks for the points raised, about being able to remove a VM while keeping the backups, my point is:
   
   - Currently, we have two Backup providers: DummyBackupProvider and VeeamBackupProvider (VMWare only).
   - Both do not allow removing a job without also removing the backups.
   
   So, imagine the scenario:
   1. A user owns a VM associated with a backup offering.
   2. The user removes the VM.
   3. The backup offering continues to exist and consequently the provider job continues to run, which may be far from the ideal scenario and may cause errors at the provider.
   
   Therefore, this PR is primarily intended to prevent the removal of a VM that has a backup offering associated with it. Also, I am marking this PR as Draft, until we I make the adjustments request by @RodrigoDLopez; the idea of showing for the user the backupofferings that the VM is associated with and its backups (if it has) is very interesting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org