You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2014/11/18 00:56:51 UTC

[GitHub] couchdb-fauxton pull request: Only render doc page breadcrumbs as ...

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/154

    Only render doc page breadcrumbs as needed

    All routes changes used to cause the breadcrumbs to be re-rendered,
    even though they often don't change. This small change checks to see
    if the crumbs have in fact changed, and only re-renders if so.
    
    Closes COUCHDB-2465

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton 2465-doc-breadcrumbs-redraws

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 666bb6bd57efe4f3f3641217f00fffa483da228f
Author: Benjamin Keen <be...@gmail.com>
Date:   2014-11-17T23:52:32Z

    Only render doc page breadcrumbs as needed
    
    All routes changes used to cause the breadcrumbs to be re-rendered,
    even though they often don't change. This small change checks to see
    if the crumbs have in fact changed, and only re-renders if so.
    
    Closes COUCHDB-2465

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Only render doc page breadcrumbs as ...

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/154#issuecomment-63900986
  
    Thanks @robertkowalski! Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Only render doc page breadcrumbs as ...

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/154#discussion_r20573122
  
    --- Diff: app/addons/fauxton/components.js ---
    @@ -52,7 +52,13 @@ function(app, FauxtonAPI, ace, spin, ZeroClipboard) {
           this.listenTo(FauxtonAPI.Events, 'lookaheadTray:close', this.unselectLastBreadcrumb);
         },
     
    -    updateCrumbs: function(crumbs){
    +    updateCrumbs: function(crumbs) {
    --- End diff --
    
    style: `function (crumbs) {`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Only render doc page breadcrumbs as ...

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/154#issuecomment-63913862
  
    Thanks! Merged as 9d43717


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Only render doc page breadcrumbs as ...

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/154


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Only render doc page breadcrumbs as ...

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/154#issuecomment-63636717
  
    +1 after addressing the minor style thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Only render doc page breadcrumbs as ...

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/154#issuecomment-63913142
  
    +1 rebase & merge it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---