[jira] [Commented] (FELIX-4696) Improve native OS version sanitation

["Bob Paulin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270523#comment-14270523 ] 

Bob Paulin commented on FELIX-4696:
-----------------------------------

Hi Felix.  Sanitizing the Version makes sense to me.  I think for the Native Capabilities I've decided to simply drop the classifier opting for a pattern of \\d+\\.?\\d*\\.?\\d* (See ExtentionManager.buildNativeCapabilites).  I know the linux os versions often include a classifier.  Do you think they are useful?

> Improve native OS version sanitation
> ------------------------------------
>
>                 Key: FELIX-4696
>                 URL: https://issues.apache.org/jira/browse/FELIX-4696
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-4.4.1
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: framework-4.6.0
>
>         Attachments: FELIX-4696.patch
>
>
> The Native OS version sanitation currently simply tries to parse the native OS version and if failing falls back to 0.0.0.
> I think it would be better to actually properly sanitize the version similar to what the DefaultMaven2OsgiConverter class of the Bundle Maven Plugin does.
> So for example, a FC9 version of "3.14.22-100.fc19.i686.PAE" would then be converted to "3.14.22.100_fc19_i686_PAE" which is much more suited to real world use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)