You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/09 01:39:39 UTC
[GitHub] [hive] lijufeng2016 opened a new pull request #1844: HIVE-24609 fix ArrayIndexOutOfBoundsException when position<0
lijufeng2016 opened a new pull request #1844:
URL: https://github.com/apache/hive/pull/1844
What changes were proposed in this pull request?
Add a judgement for position.
Why are the changes needed?
To aviod ArrayIndexOutOfBoundsException
Does this PR introduce any user-facing change?
No
How was this patch tested?
It's OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1844: HIVE-24609: fix ArrayIndexOutOfBoundsException when position<0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1844:
URL: https://github.com/apache/hive/pull/1844#issuecomment-796332588
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #1844: HIVE-24609: fix ArrayIndexOutOfBoundsException when position<0
Posted by GitBox <gi...@apache.org>.
ashish-kumar-sharma commented on a change in pull request #1844:
URL: https://github.com/apache/hive/pull/1844#discussion_r663063144
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
##########
@@ -1629,6 +1629,9 @@ private boolean checkShuffleSizeForLargeTable(JoinOperator joinOp, int position,
// Max is disabled, we can safely return false
return false;
}
+ if(position < 0){
Review comment:
@lijufeng2016 Please reopen the PR. Also add a UTs and qtest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lijufeng2016 commented on pull request #1844: HIVE-24609: fix ArrayIndexOutOfBoundsException when position<0
Posted by GitBox <gi...@apache.org>.
lijufeng2016 commented on pull request #1844:
URL: https://github.com/apache/hive/pull/1844#issuecomment-806383764
> ### **What changes were proposed in this pull request?**
> Add a judgement for position.
>
> ### **Why are the changes needed?**
> To aviod ArrayIndexOutOfBoundsException
>
> ### **Does this PR introduce any user-facing change?**
> No
>
> ### **How was this patch tested?**
can someone review that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1844: HIVE-24609: fix ArrayIndexOutOfBoundsException when position<0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1844:
URL: https://github.com/apache/hive/pull/1844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org