You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by exabrial <gi...@git.apache.org> on 2017/06/22 17:26:37 UTC
[GitHub] cxf pull request #285: [WIP] Fixing CNFE build errors when building under JD...
GitHub user exabrial opened a pull request:
https://github.com/apache/cxf/pull/285
[WIP] Fixing CNFE build errors when building under JDK1.8 using toolchains
[WIP] Fixing CNFE build errors when building under JDK1.8 using toolchains
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tomitribe/cxf cxf-outbound
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/285.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #285
----
commit 7dea76414107e70ecca7ba06b1346c48c70dada2
Author: Jonathan S. Fisher <jf...@tomitribe.com>
Date: 2017-06-20T15:29:08Z
Fix build to work!
commit 88b72ce73d327119d9a8220cd9245803815fd079
Author: Jonathan S. Fisher <ex...@gmail.com>
Date: 2017-06-22T17:25:15Z
Merge pull request #5 from exabrial/cxf-outbound
[WIP] Merge changes from cxf upstream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #285: [WIP] Fixing CNFE build errors when building under JD...
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on a diff in the pull request:
https://github.com/apache/cxf/pull/285#discussion_r124908866
--- Diff: systests/databinding/pom.xml ---
@@ -165,7 +165,7 @@
<plugin>
<groupId>org.jibx</groupId>
<artifactId>maven-jibx-plugin</artifactId>
- <version>${cxf.jibx.version}</version>
+ <version>1.3.1</version>
--- End diff --
Why are you removing a property version and putting a hard coded version number in there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #285: [WIP] Fixing CNFE build errors when building under JD...
Posted by exabrial <gi...@git.apache.org>.
Github user exabrial commented on a diff in the pull request:
https://github.com/apache/cxf/pull/285#discussion_r124920060
--- Diff: systests/databinding/pom.xml ---
@@ -165,7 +165,7 @@
<plugin>
<groupId>org.jibx</groupId>
<artifactId>maven-jibx-plugin</artifactId>
- <version>${cxf.jibx.version}</version>
+ <version>1.3.1</version>
--- End diff --
Hey Daniel!
I think because the version specified by the variable is needed to make the code compile and produce the correct artifacts (the bindings), but the plugin needs to be a newer version to work with JDK 1.8 and modern maven.
Keep in mind I have this branch marked WIP as I sort bugs out. The goal is to fix all the known CVEs in 2.6 and make it buildable without having to maintain a separate environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #285: [WIP] Fixing CNFE build errors when building under JDK1.8 us...
Posted by exabrial <gi...@git.apache.org>.
Github user exabrial commented on the issue:
https://github.com/apache/cxf/pull/285
Yes, thanks
On Jul 27, 2017 4:42 AM, "Colm O hEigeartaigh" <no...@github.com>
wrote:
> *@coheigea* commented on this pull request.
> ------------------------------
>
> In systests/databinding/pom.xml
> <https://github.com/apache/cxf/pull/285#discussion_r129796686>:
>
> > @@ -165,7 +165,7 @@
> <plugin>
> <groupId>org.jibx</groupId>
> <artifactId>maven-jibx-plugin</artifactId>
> - <version>${cxf.jibx.version}</version>
> + <version>1.3.1</version>
>
> Can this PR be closed? We can't apply the fix as otherwise the branch
> won't build with older JDK versions.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cxf/pull/285#discussion_r129796686>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABU-qTeK2WQ43zv36PRS1UoJ3B74mNolks5sSFt8gaJpZM4OCmpl>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #285: [WIP] Fixing CNFE build errors when building under JDK1.8 us...
Posted by coheigea <gi...@git.apache.org>.
Github user coheigea commented on the issue:
https://github.com/apache/cxf/pull/285
This doesn't work with JDK 1.6:
Failed to execute goal org.jibx:maven-jibx-plugin:1.3.1:test-bind (default) on project cxf-systests-databinding: org/apache/bcel/classfile/Attribute : Unsupported major.minor version 51.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #285: [WIP] Fixing CNFE build errors when building under JD...
Posted by coheigea <gi...@git.apache.org>.
Github user coheigea commented on a diff in the pull request:
https://github.com/apache/cxf/pull/285#discussion_r129796686
--- Diff: systests/databinding/pom.xml ---
@@ -165,7 +165,7 @@
<plugin>
<groupId>org.jibx</groupId>
<artifactId>maven-jibx-plugin</artifactId>
- <version>${cxf.jibx.version}</version>
+ <version>1.3.1</version>
--- End diff --
Can this PR be closed? We can't apply the fix as otherwise the branch won't build with older JDK versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #285: [WIP] Fixing CNFE build errors when building under JD...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cxf/pull/285
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---