[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10210: feat: Typeahead searchable filter_box for dashboard

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #10210:
URL: https://github.com/apache/incubator-superset/pull/10210#discussion_r448722762



##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
##########
@@ -202,6 +220,21 @@ export default class FilterBoxItemControl extends React.Component {
             />
           }
         />
+        <FormRow
+          label={t('Fixed Filter Options')}
+          tooltip={t(
+            'By default, filter box will only load top 1000 filter options once. ' +
+              'When disabled, filter box will load options from a remote source as the user types, ' +
+              'with 1000 options per load.',

Review comment:
       let me check with PM tomorrow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org