You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by emlaver <gi...@git.apache.org> on 2017/04/05 17:38:52 UTC
[GitHub] bahir pull request #40: [BAHIR-101] updates to sql-cloudant readme and pytho...
GitHub user emlaver opened a pull request:
https://github.com/apache/bahir/pull/40
[BAHIR-101] updates to sql-cloudant readme and python examples
- Updated documentation according to the README.md template so it can be compiled into http://bahir.apache.org/docs/spark/current/documentation/ automatically
- Fixed print call when testing examples in Python 3.x
@yanglei99 FYI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emlaver/bahir sql-cloudant-readme-examples
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit a1f47c30020d087bc5ff77f7e7f2c94ebf1c0246
Author: Esteban Laver <em...@us.ibm.com>
Date: 2017-04-03T22:05:44Z
Updated documentation according to the README.md template
commit 3c57d7c7425bd61544ed6068748bd1715d08fdd0
Author: Esteban Laver <em...@us.ibm.com>
Date: 2017-04-05T17:14:31Z
Fixed print call when testing examples in Python 3.x
- Removed unnecessary import
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/40
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/40
Build successful
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/40
@emlaver Sorry, I didn't realized this was re-using the same jira for cloudant initial code. Next time create a new jira so it becomes easier to count your contributions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/40
Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/bahir_spark_pr_builder/52/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/40
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/40
Build successful
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...
Posted by emlaver <gi...@git.apache.org>.
Github user emlaver commented on the issue:
https://github.com/apache/bahir/pull/40
@lresende Ok, no problem, I'll make sure to open a new JIRA for the next one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir pull request #40: [BAHIR-101] updates to sql-cloudant readme and pytho...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/40#discussion_r110016552
--- Diff: sql-cloudant/README.md ---
@@ -1,24 +1,10 @@
-Spark Cloudant Connector
-================
+A library for reading data from Cloudant databases using Spark SQL and Spark Streaming.
-Cloudant integration with Spark as Spark SQL external datasource, and Spark Streaming as a custom receiver.
-
-
-## Contents:
-0. [Linking](#Linking)
-1. [Implementation of RelationProvider](#implementation-of-relationProvider)
-2. [Implementation of Receiver](#implementation-of-Receiver)
-3. [Sample applications](#Sample-application)
- 1. [Using SQL In Python](#Using-SQL-In-Python)
- 2. [Using SQL In Scala](#Using-SQL-In-Scala)
- 3. [Using DataFrame In Python](#Using-DataFrame-In-Python)
- 4. [Using DataFrame In Scala](#Using-DataFrame-In-Scala)
- 5. [Using Streams In Scala](#Using-Streams-In-Scala)
-4. [Configuration Overview](#Configuration-Overview)
-5. [Known limitations and areas for improvement](#Known-limitations)
-
-
-<div id='Linking'/>
+[IBM� Cloudant�](https://cloudant.com) is a document-oriented DataBase as a Service (DBaaS). It stores data as documents
--- End diff --
Can we make sure we also mention that this works for vanilla Apache CounchDB as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #40: [BAHIR-101] updates to sql-cloudant readme and python examp...
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/40
Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/bahir_spark_pr_builder/51/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir pull request #40: [BAHIR-101] updates to sql-cloudant readme and pytho...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---