You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/20 16:36:14 UTC

[GitHub] [flink] dusukang opened a new pull request, #20025: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

dusukang opened a new pull request, #20025:
URL: https://github.com/apache/flink/pull/20025

   ## What is the purpose of the change
   Use MysqlCatalog to get the PK of tables which have same table name in different databases.
   
   ## Brief change log
   Modify the method parameters for get MySQL primary key.
   
   ## Verifying this change
   This change is a code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dusukang commented on pull request #20025: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

Posted by GitBox <gi...@apache.org>.
dusukang commented on PR #20025:
URL: https://github.com/apache/flink/pull/20025#issuecomment-1161564422

   cc @leonardBang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang merged pull request #20025: [FLINK-27794][connectors/jdbc] Fix the wrong primary key for MysqlCatalog when there are tables with same name in different databases

Posted by GitBox <gi...@apache.org>.
leonardBang merged PR #20025:
URL: https://github.com/apache/flink/pull/20025


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dusukang commented on pull request #20025: [FLINK-27794][connectors/jdbc] Fix the wrong primary key for MysqlCatalog when there are tables with same name in different databases

Posted by GitBox <gi...@apache.org>.
dusukang commented on PR #20025:
URL: https://github.com/apache/flink/pull/20025#issuecomment-1165315544

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20025: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20025:
URL: https://github.com/apache/flink/pull/20025#issuecomment-1160657491

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ffdc3d70180b50b14d22684ad0d1891bdeeb2e38",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ffdc3d70180b50b14d22684ad0d1891bdeeb2e38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ffdc3d70180b50b14d22684ad0d1891bdeeb2e38 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dusukang commented on pull request #20025: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

Posted by GitBox <gi...@apache.org>.
dusukang commented on PR #20025:
URL: https://github.com/apache/flink/pull/20025#issuecomment-1160962135

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dusukang commented on pull request #20025: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

Posted by GitBox <gi...@apache.org>.
dusukang commented on PR #20025:
URL: https://github.com/apache/flink/pull/20025#issuecomment-1161118263

   cc@leonardBang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dusukang commented on pull request #20025: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

Posted by GitBox <gi...@apache.org>.
dusukang commented on PR #20025:
URL: https://github.com/apache/flink/pull/20025#issuecomment-1160962919

   see[https://github.com/apache/flink/pull/19741](https://github.com/apache/flink/pull/19741)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dusukang commented on pull request #20025: [FLINK-27794][connectors/jdbc] Fix the wrong primary key for MysqlCatalog when there are tables with same name in different databases

Posted by GitBox <gi...@apache.org>.
dusukang commented on PR #20025:
URL: https://github.com/apache/flink/pull/20025#issuecomment-1164250825

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on pull request #20025: [FLINK-27794][connectors/jdbc] Fix the wrong primary key for MysqlCatalog when there are tables with same name in different databases

Posted by GitBox <gi...@apache.org>.
leonardBang commented on PR #20025:
URL: https://github.com/apache/flink/pull/20025#issuecomment-1165503434

   Thanks @dusukang for the contribution, LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org