You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/12/14 21:38:46 UTC
[GitHub] [cassandra] yifan-c commented on a change in pull request #1357: CASSANDRA-17142: Limit the maximum hints size per host
yifan-c commented on a change in pull request #1357:
URL: https://github.com/apache/cassandra/pull/1357#discussion_r769065475
##########
File path: conf/cassandra.yaml
##########
@@ -63,6 +63,11 @@ hinted_handoff_enabled: true
# created until it has been seen alive and gone down again.
max_hint_window_in_ms: 10800000 # 3 hours
+# The file size limit to store hints for an unreachable host.
+# Once the local hints files have reached the limit, no more new hints will be created.
+# Set a non-positive value will disable the size limit.
+max_hints_size_per_host_in_mb: 0
Review comment:
There are other configurations like `max_hints_delivery_threads` and `max_hints_file_size_in_mb` that all use the plural form. Only `max_hint_window_in_ms` is using the singular form. I will keep the current one to be consistent with the majority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org