You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/08/04 22:59:56 UTC
Review Request 24261: Add deprecation warnings to other clientv1 commands.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24261/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Joe Smith.
Repository: aurora
Description
-------
Add deprecation warnings to other clientv1 commands.
Diffs
-----
src/main/python/apache/aurora/client/commands/run.py 169327f1846ce5ba571645e019ce6a70f8f205f0
src/main/python/apache/aurora/client/commands/ssh.py 38233382ee19aa587d6ad7e5d2f4d270c9a5d9d6
Diff: https://reviews.apache.org/r/24261/diff/
Testing
-------
[sun-wukong incubator-aurora (deprecation2)]$ ./dist/aurora2.pex ssh example/mchucarroll/test/foo 2 ls
WARNING: ssh is an aurora clientv1 command which will be deprecated soon
To run this command using clientv2, use 'aurora task ssh example/mchucarroll/test/foo/2 --command="ls"'
[sun-wukong incubator-aurora (deprecation2)]$ ./dist/aurora2.pex run example/mchucarroll/test/foo ls -la
WARNING: ssh is an aurora clientv1 command which will be deprecated soon
To run this command using clientv2, use 'aurora task run "ls -la"'
Thanks,
Mark Chu-Carroll
Re: Review Request 24261: Add deprecation warnings to other clientv1
commands.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24261/#review49529
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Aug. 4, 2014, 8:59 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24261/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 8:59 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Joe Smith.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add deprecation warnings to other clientv1 commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/run.py 169327f1846ce5ba571645e019ce6a70f8f205f0
> src/main/python/apache/aurora/client/commands/ssh.py 38233382ee19aa587d6ad7e5d2f4d270c9a5d9d6
>
> Diff: https://reviews.apache.org/r/24261/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (deprecation2)]$ ./dist/aurora2.pex ssh example/mchucarroll/test/foo 2 ls
> WARNING: ssh is an aurora clientv1 command which will be deprecated soon
> To run this command using clientv2, use 'aurora task ssh example/mchucarroll/test/foo/2 --command="ls"'
>
> [sun-wukong incubator-aurora (deprecation2)]$ ./dist/aurora2.pex run example/mchucarroll/test/foo ls -la
> WARNING: ssh is an aurora clientv1 command which will be deprecated soon
> To run this command using clientv2, use 'aurora task run "ls -la"'
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 24261: Add deprecation warnings to other clientv1
commands.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24261/#review49525
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Aug. 4, 2014, 1:59 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24261/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 1:59 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Joe Smith.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add deprecation warnings to other clientv1 commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/run.py 169327f1846ce5ba571645e019ce6a70f8f205f0
> src/main/python/apache/aurora/client/commands/ssh.py 38233382ee19aa587d6ad7e5d2f4d270c9a5d9d6
>
> Diff: https://reviews.apache.org/r/24261/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (deprecation2)]$ ./dist/aurora2.pex ssh example/mchucarroll/test/foo 2 ls
> WARNING: ssh is an aurora clientv1 command which will be deprecated soon
> To run this command using clientv2, use 'aurora task ssh example/mchucarroll/test/foo/2 --command="ls"'
>
> [sun-wukong incubator-aurora (deprecation2)]$ ./dist/aurora2.pex run example/mchucarroll/test/foo ls -la
> WARNING: ssh is an aurora clientv1 command which will be deprecated soon
> To run this command using clientv2, use 'aurora task run "ls -la"'
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>