You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by scwf <gi...@git.apache.org> on 2014/04/16 17:49:10 UTC
[GitHub] spark pull request: [SPARK-1512] improve spark sql to support tabl...
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/428
[SPARK-1512] improve spark sql to support table with more than 22 fields
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scwf/spark sql2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/428.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #428
----
commit 011e3cb9163324bd6cd4e20c7eaaa4980a855bc1
Author: wangfei <wa...@huawei.com>
Date: 2014-04-16T14:45:04Z
Update ScalaReflection.scala
commit 0f993ca3f3f04d11ac37c1ecdaa9b7666d60418b
Author: wangfei <wa...@huawei.com>
Date: 2014-04-16T14:46:14Z
Update ScalaReflection.scala
commit d4910a6ca0f229b6e6680b376b91a81e2388e3e9
Author: wangfei <wa...@huawei.com>
Date: 2014-04-16T14:48:03Z
Update SQLContext.scala
commit 36c4d2fa421cd83581c6ebe344344bb03438c1f4
Author: wangfei <wa...@huawei.com>
Date: 2014-04-16T14:48:56Z
Update basicOperators.scala
commit 37c8a7d4fea48a765d0b9372485bc7f052fe02a9
Author: wangfei <wa...@huawei.com>
Date: 2014-04-16T14:50:30Z
Create RecordClass
commit edc4619f7e90e2bf326f40b18510f49f2d00b262
Author: wangfei <wa...@huawei.com>
Date: 2014-04-16T14:51:10Z
Rename RecordClass to RecordClass.scala
commit f5a9b348b0cfc04bcd9a946a8449f390c14aca79
Author: wangfei <wa...@huawei.com>
Date: 2014-04-16T14:52:29Z
Create WideRecordRelation.scala
commit 651a6df4269f795c875acfe09f50518b6a2a24ed
Author: wangfei <wa...@huawei.com>
Date: 2014-04-16T15:32:01Z
Update SQLContext.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1512] improve spark sql to support tabl...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/428#issuecomment-40668570
Thanks for submitting this. Actually Spark SQL/catalyst itself already supports more than 22 fields. It's just that case classes in Scala 2.10 doesn't. As long as the user's class (not case classes) implements the Product interface, it should be fine.
Instead of introducing a new API, do you mind updating the documentation to indicate that? (i.e. any concrete implementations of Product are fine; case class is merely a special example of that)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1512] improve spark sql to support tabl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/428#issuecomment-40616313
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1512] improve spark sql to support tabl...
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/428#issuecomment-40690569
hi, i update this patch to an example that query table with more than 22 fields by implementing the Product interface
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1512] improve spark sql to support tabl...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/428#issuecomment-40671798
The upcoming Scala 2.11 now supports case classes with more than 22 fields https://issues.scala-lang.org/browse/SI-7296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1512] improve spark sql to support tabl...
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/428#issuecomment-40672184
ok, i will update the doc to indicate this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1512] improve spark sql to support tabl...
Posted by scwf <gi...@git.apache.org>.
Github user scwf closed the pull request at:
https://github.com/apache/spark/pull/428
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---