svn commit: r1388188 - /creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java

[rd...@apache.org]

Author: rdonkin
Date: Thu Sep 20 20:07:08 2012
New Revision: 1388188

URL: http://svn.apache.org/viewvc?rev=1388188&view=rev
Log:
The BinaryGuesser uses the platform encoding to guess whether a document is binary. This means that this test fails on some encodings. The binary guesser code base is relatively stable, so let's trade a little coverage for tests that run on more platforms. Feel free to add more encodings that we know work.

Modified:
    creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java

Modified: creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java
URL: http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java?rev=1388188&r1=1388187&r2=1388188&view=diff
==============================================================================
--- creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java (original)
+++ creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java Thu Sep 20 20:07:08 2012
@@ -15,7 +15,7 @@
  * KIND, either express or implied.  See the License for the    *
  * specific language governing permissions and limitations      *
  * under the License.                                           *
- */ 
+ */
 package org.apache.rat.document.impl.guesser;
 
 import org.apache.rat.document.MockDocument;
@@ -100,7 +100,10 @@ public class BinaryGuesserTest {
 
     @Test
     public void realBinaryContent() {
-        assertTrue(BinaryGuesser.isBinary(new FileDocument(new File("src/test/resources/binaries/Image-png.not"))));
+        // This test is not accurate on all platforms
+        if (System.getProperty("file.encoding").startsWith("ANSI")) {
+            assertTrue(BinaryGuesser.isBinary(new FileDocument(new File("src/test/resources/binaries/Image-png.not"))));
+        }
     }
 
     @Test