You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/03 23:22:00 UTC

[jira] [Commented] (GROOVY-8402) GroovyScriptEngine.ScriptClassLoader applies compilation customizers twice

    [ https://issues.apache.org/jira/browse/GROOVY-8402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276156#comment-16276156 ] 

ASF GitHub Bot commented on GROOVY-8402:
----------------------------------------

GitHub user shils opened a pull request:

    https://github.com/apache/groovy/pull/641

    GROOVY-8402: GroovyScriptEngine.ScriptClassLoader applies compilation…

    … customizers twice

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shils/groovy GROOVY-8402

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/641.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #641
    
----
commit 1b660cfae31b56aa2a33739f078513ac8d78c19b
Author: Shil Sinha <sh...@apache.org>
Date:   2017-12-03T23:19:57Z

    GROOVY-8402: GroovyScriptEngine.ScriptClassLoader applies compilation customizers twice

----


> GroovyScriptEngine.ScriptClassLoader applies compilation customizers twice
> --------------------------------------------------------------------------
>
>                 Key: GROOVY-8402
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8402
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.4.13
>            Reporter: Shil Sinha
>            Assignee: Shil Sinha
>
> ScriptClassLoader.createCompilationUnit calls super.createCompilationUnit, which initializes a new CompilationUnit. As phase operations for compilation customizers are already added in the constructor for CompilationUnit, they should not be added again at the end of ScriptClassLoader.createCompilationUnit.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)