You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/25 03:34:32 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #43086: [SPARK-28932][BUILD] Remove org.scala-lang scala-library added for JDK 11 workaround

HyukjinKwon opened a new pull request, #43086:
URL: https://github.com/apache/spark/pull/43086

   ### What changes were proposed in this pull request?
   
   This PR removes the legacy workaround for JDK 11 added at SPARK-28932
   
   ### Why are the changes needed?
   
   To remove legacy workaround. With JDK 17, now it seems working.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   As described in https://github.com/apache/spark/pull/25800
   
   ```bash
   ./build/mvn clean install -pl common/network-common -DskipTests
   ```
   
   ```
   ...
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  48.139 s
   [INFO] Finished at: 2023-09-25T12:27:43+09:00
   [INFO] ------------------------------------------------------------------------
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #43086: [SPARK-28932][BUILD] Remove org.scala-lang scala-library added for JDK 11 workaround

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43086:
URL: https://github.com/apache/spark/pull/43086#issuecomment-1732851718

   cc @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #43086: [SPARK-45301][BUILD] Remove org.scala-lang scala-library added for JDK 11 workaround

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43086: [SPARK-45301][BUILD] Remove org.scala-lang scala-library added for JDK 11 workaround
URL: https://github.com/apache/spark/pull/43086


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org