You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2015/09/10 02:28:12 UTC

Review Request 38240: Renamed appc_backend flag to appc_provisioner_backend.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38240/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Renamed appc_backend flag to appc_provisioner_backend.


Diffs
-----

  src/slave/containerizer/provisioners/appc/appc.cpp d54b6882346df7121ec63803810fab979ac0848a 
  src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c 
  src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d 
  src/tests/containerizer/appc_provisioner_tests.cpp f30e1a1dee9a68be01133117339d91771f15988c 

Diff: https://reviews.apache.org/r/38240/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request 38240: Renamed appc_backend flag to appc_provisioner_backend.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38240/#review98322
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Sept. 10, 2015, 12:28 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38240/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 12:28 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed appc_backend flag to appc_provisioner_backend.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioners/appc/appc.cpp d54b6882346df7121ec63803810fab979ac0848a 
>   src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c 
>   src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d 
>   src/tests/containerizer/appc_provisioner_tests.cpp f30e1a1dee9a68be01133117339d91771f15988c 
> 
> Diff: https://reviews.apache.org/r/38240/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request 38240: Renamed appc_backend flag to appc_provisioner_backend.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38240/#review98395
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On Sept. 10, 2015, 7 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38240/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 7 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed appc_backend flag to appc_provisioner_backend.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioners/appc/provisioner.cpp d54b6882346df7121ec63803810fab979ac0848a 
>   src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c 
>   src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d 
>   src/tests/containerizer/appc_provisioner_tests.cpp f30e1a1dee9a68be01133117339d91771f15988c 
> 
> Diff: https://reviews.apache.org/r/38240/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request 38240: Renamed appc_backend flag to appc_provisioner_backend.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38240/
-----------------------------------------------------------

(Updated Sept. 10, 2015, midnight)


Review request for mesos and Jie Yu.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Renamed appc_backend flag to appc_provisioner_backend.


Diffs (updated)
-----

  src/slave/containerizer/provisioners/appc/provisioner.cpp d54b6882346df7121ec63803810fab979ac0848a 
  src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c 
  src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d 
  src/tests/containerizer/appc_provisioner_tests.cpp f30e1a1dee9a68be01133117339d91771f15988c 

Diff: https://reviews.apache.org/r/38240/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu