You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by wang yuan <wa...@zte.com.cn> on 2017/09/23 10:14:02 UTC
Review Request 62522: The exception information is error when judge
password for RangerKeyStoreProvider class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1804
https://issues.apache.org/jira/browse/RANGER-1804
Repository: ranger
Description
-------
The exception information is error when judge password for RangerKeyStoreProvider class
I think it should throw the password is error instead of throw master key not exists.
{code}
String password = conf.get(ENCRYPTION_KEY);
if(password == null || password.trim().equals("") || password.trim().equals("_") || password.trim().equals("crypted")){
throw new IOException("Master Key Jceks does not exists");
}
{code}
Diffs
-----
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 267fcf08
Diff: https://reviews.apache.org/r/62522/diff/1/
Testing
-------
Thanks,
wang yuan
Re: Review Request 62522: The exception information is error when
judge password for RangerKeyStoreProvider class
Posted by wang yuan <wa...@zte.com.cn>.
> On 九月 25, 2017, 2:20 p.m., Colm O hEigeartaigh wrote:
> > I would leave in "Master Key" to make it clearer, e.g. "The Master Key Password is empty or not a valid password"
You are right,Colm O hEigeartaigh .I'll fix it.
Thanks.
- wang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/#review186121
-----------------------------------------------------------
On 九月 25, 2017, 5:47 a.m., wang yuan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62522/
> -----------------------------------------------------------
>
> (Updated 九月 25, 2017, 5:47 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1804
> https://issues.apache.org/jira/browse/RANGER-1804
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The exception information is error when judge password for RangerKeyStoreProvider class
> I think it should throw the password is error instead of throw master key not exists.
> {code}
> String password = conf.get(ENCRYPTION_KEY);
> if(password == null || password.trim().equals("") || password.trim().equals("_") || password.trim().equals("crypted")){
> throw new IOException("Master Key Jceks does not exists");
> }
> {code}
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 267fcf08
>
>
> Diff: https://reviews.apache.org/r/62522/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> wang yuan
>
>
Re: Review Request 62522: The exception information is error when
judge password for RangerKeyStoreProvider class
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/#review186121
-----------------------------------------------------------
I would leave in "Master Key" to make it clearer, e.g. "The Master Key Password is empty or not a valid password"
- Colm O hEigeartaigh
On Sept. 25, 2017, 5:47 a.m., wang yuan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62522/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2017, 5:47 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1804
> https://issues.apache.org/jira/browse/RANGER-1804
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The exception information is error when judge password for RangerKeyStoreProvider class
> I think it should throw the password is error instead of throw master key not exists.
> {code}
> String password = conf.get(ENCRYPTION_KEY);
> if(password == null || password.trim().equals("") || password.trim().equals("_") || password.trim().equals("crypted")){
> throw new IOException("Master Key Jceks does not exists");
> }
> {code}
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 267fcf08
>
>
> Diff: https://reviews.apache.org/r/62522/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> wang yuan
>
>
Re: Review Request 62522: The exception information is error when
judge password for RangerKeyStoreProvider class
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/#review186231
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 26, 2017, 7:35 a.m., wang yuan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62522/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 7:35 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1804
> https://issues.apache.org/jira/browse/RANGER-1804
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The exception information is error when judge password for RangerKeyStoreProvider class
> I think it should throw the password is error instead of throw master key not exists.
> {code}
> String password = conf.get(ENCRYPTION_KEY);
> if(password == null || password.trim().equals("") || password.trim().equals("_") || password.trim().equals("crypted")){
> throw new IOException("Master Key Jceks does not exists");
> }
> {code}
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 267fcf08
>
>
> Diff: https://reviews.apache.org/r/62522/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> wang yuan
>
>
Re: Review Request 62522: The exception information is error when
judge password for RangerKeyStoreProvider class
Posted by wang yuan <wa...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/
-----------------------------------------------------------
(Updated 九月 26, 2017, 7:35 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1804
https://issues.apache.org/jira/browse/RANGER-1804
Repository: ranger
Description
-------
The exception information is error when judge password for RangerKeyStoreProvider class
I think it should throw the password is error instead of throw master key not exists.
{code}
String password = conf.get(ENCRYPTION_KEY);
if(password == null || password.trim().equals("") || password.trim().equals("_") || password.trim().equals("crypted")){
throw new IOException("Master Key Jceks does not exists");
}
{code}
Diffs (updated)
-----
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 267fcf08
Diff: https://reviews.apache.org/r/62522/diff/4/
Changes: https://reviews.apache.org/r/62522/diff/3-4/
Testing
-------
Thanks,
wang yuan
Re: Review Request 62522: The exception information is error when
judge password for RangerKeyStoreProvider class
Posted by wang yuan <wa...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/
-----------------------------------------------------------
(Updated 九月 26, 2017, 7:30 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1804
https://issues.apache.org/jira/browse/RANGER-1804
Repository: ranger
Description
-------
The exception information is error when judge password for RangerKeyStoreProvider class
I think it should throw the password is error instead of throw master key not exists.
{code}
String password = conf.get(ENCRYPTION_KEY);
if(password == null || password.trim().equals("") || password.trim().equals("_") || password.trim().equals("crypted")){
throw new IOException("Master Key Jceks does not exists");
}
{code}
Diffs (updated)
-----
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 267fcf08
Diff: https://reviews.apache.org/r/62522/diff/3/
Changes: https://reviews.apache.org/r/62522/diff/2-3/
Testing
-------
Thanks,
wang yuan
Re: Review Request 62522: The exception information is error when
judge password for RangerKeyStoreProvider class
Posted by wang yuan <wa...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/
-----------------------------------------------------------
(Updated 九月 25, 2017, 5:47 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1804
https://issues.apache.org/jira/browse/RANGER-1804
Repository: ranger
Description
-------
The exception information is error when judge password for RangerKeyStoreProvider class
I think it should throw the password is error instead of throw master key not exists.
{code}
String password = conf.get(ENCRYPTION_KEY);
if(password == null || password.trim().equals("") || password.trim().equals("_") || password.trim().equals("crypted")){
throw new IOException("Master Key Jceks does not exists");
}
{code}
Diffs (updated)
-----
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 267fcf08
Diff: https://reviews.apache.org/r/62522/diff/2/
Changes: https://reviews.apache.org/r/62522/diff/1-2/
Testing
-------
Thanks,
wang yuan