You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/07/15 06:37:48 UTC
[GitHub] [dolphinscheduler] yc322 opened a new issue #5822: [Feature][service]add audit fuction
yc322 opened a new issue #5822:
URL: https://github.com/apache/dolphinscheduler/issues/5822
**[Feature][service]add audit fuction**
**Feature Desciption**
This function records the operations that users successfully perform to change the database, such as creating queue, creating workflow and so on. User can determine whether audit function turn on or not through the switch setting. The default implementation mode of the audit data is written to MySQL, and the extension interface is provided to store the data in other ways. The audit log is displayed on the front page, and the basic filtering operation is provided.
该功能记录用户成功执行的对数据库有改动的操作，如创建队列、创建工作流等操作。通过开关设置是否开启审计功能, 审计的数据
默认提供的实现方式是写入mysql,并且提供扩展接口实现使用其他方式存储。在前端页面上展示审计日志，并且提供基本的筛选操作。
**why this new feature usefule for most users**
1. Improve the security of the system, audit function records the modification and operator of the database, which is convenient to view the specific reasons when the business is modified.
2. Users can view the historical behavior, and can trace back according to the operation history when the business has problems
3. Only gateway logs andworkflow output logs are recorded. There is a lack of record and display of the user's successful execution and modification of the database.
1. 提高系统安全性，审计功能记录下数据库的修改和操作人，方便在业务被修改等情况查看具体原因。
2. 用户能够查看历史行为，在业务出现问题的时候，可以根据操作历史进行回溯
3. 目前只记录了网关日志，以及用户定义的工作流输出日志。缺乏对用户已执行成功的，且对数据库有修改的行为的记录和展示。
**Design plan**
Plan a: publish and subscribe mode . After user completes the modification operation, the operation behavior information is published as the form of message
Plan B: implementation using AOP
plan A:采用发布订阅模式，用户修改操作执行完成后，将操作行为信息以消息的方式进行发布
plan B:使用AOP进行实现
Audit Log Schema Design
| Module | Type | IP | operator | time |
| --- | --- | --- | --- | --- |
| workflow definition | create workflow | 124.202.192.246 | admin | 2021-10-11 12:11:10 |
**Additional context**
Airflow provides basic user behavior recording and viewing functions, recording the time, operator, event, parameter and other information of operation.
airflow提供了基本的用户行为记录和查看功能，记录了用户操作的时间、操作人、事件、参数等信息。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on issue #5822: [Feature][service]add audit fuction
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #5822:
URL: https://github.com/apache/dolphinscheduler/issues/5822#issuecomment-886394226
> > good suggestion, many users also feedbacked that they need this feature
> > BTW, which plan do you prefer?
>
> AOP can be used to get the relevant operation records in the form of log after the end of user operation, but it is not convenient to judge whether the operation is successful.
>
> If use the publish subscribe mode , a message can be sent to the subscriber after the user's operation is successful.
>
> If only need to record the successfully configuration modification, it will be better to use publish and subscribe mode.
sorry for reply late, got it, I agree with what you said,
good job, please send the plan to dev@dolphinscheduler.apache.org, import things need to happen in mailing list, thx
at the same time, I am looking forwarding to your PR to implement it ^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #5822: [Feature][service]add audit fuction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #5822:
URL: https://github.com/apache/dolphinscheduler/issues/5822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on issue #5822: [Feature][service]add audit fuction
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #5822:
URL: https://github.com/apache/dolphinscheduler/issues/5822#issuecomment-881579148
good suggestion, many users also feedbacked that they need this feature
BTW, which plan do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5822: [Feature][service]add audit fuction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5822:
URL: https://github.com/apache/dolphinscheduler/issues/5822#issuecomment-1008453604
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5822: [Feature][service]add audit fuction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5822:
URL: https://github.com/apache/dolphinscheduler/issues/5822#issuecomment-1014967229
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5822: [Feature][service]add audit fuction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5822:
URL: https://github.com/apache/dolphinscheduler/issues/5822#issuecomment-880437275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] yc322 commented on issue #5822: [Feature][service]add audit fuction
Posted by GitBox <gi...@apache.org>.
yc322 commented on issue #5822:
URL: https://github.com/apache/dolphinscheduler/issues/5822#issuecomment-882023608
> good suggestion, many users also feedbacked that they need this feature
>
> BTW, which plan do you prefer?
AOP can be used to get the relevant operation records in the form of log after the end of user operation, but it is not convenient to judge whether the operation is successful.
If use the publish subscribe mode , a message can be sent to the subscriber after the user's operation is successful.
If only need to record the successfully configuration modification, it will be better to use publish and subscribe mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org