You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/12/06 22:30:43 UTC

Re: Review Request: Fix for webui file download links.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7994/#review14107
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 9, 2012, 11:26 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7994/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 11:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> We need to get the file from the slave's host, rather than the master.
> 
> 
> This addresses bug MESOS-307.
>     https://issues.apache.org/jira/browse/MESOS-307
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/browse.html 3e4374b19da25ff696fc4fab99568861238d277a 
>   src/webui/master/static/controllers.js dcb947175898c1d94837705abe21fab90d2addf3 
> 
> Diff: https://reviews.apache.org/r/7994/diff/
> 
> 
> Testing
> -------
> 
> Local runs, ensuring the slave's pid is used to parse the hostname.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>