[GitHub] [druid] vogievetsky commented on issue #13816: Improve MSQ Rollup Experience with Catalog Integration

["vogievetsky (via GitHub)" <gi...@apache.org>]

vogievetsky commented on issue #13816:
URL: https://github.com/apache/druid/issues/13816#issuecomment-1441117260

   This looks good to me from a users perspective I like the user facing parts of this proposal.
   
   I just have one note: under `Catalog Datasource Metadata Revision` I do not like the idea that the type of the table rollup or detail is determined by the presence of a measure column (also in Druid they are called "metric"). I would much prefer to have an explicit flag to set, it could default to detail. Firstly it is technically valid to have a rollup table with no measures (if you simply want to dedupe data) but more importantly I don't want to have to scan all the column to derive the type of the table (like in the console). I also think it would be better if adding a column did not magically change the type of the table ever (reducing the `COUNT(*)`). Having a rollup marked table with a measure column should yield and error.
   
   Also a typo: `add-tech` => `ad-tech`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org