You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hustfxj <gi...@git.apache.org> on 2016/03/06 09:33:08 UTC
[GitHub] storm pull request: [STORM-1606] print the information of testcase...
GitHub user hustfxj opened a pull request:
https://github.com/apache/storm/pull/1189
[STORM-1606] print the information of testcase which is on failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hustfxj/storm travis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1189
----
commit 812031ff7e3017dfcbff4c3434fbd3c2437dcb33
Author: xiaojian.fxj <xi...@alibaba-inc.com>
Date: 2016-03-06T08:24:22Z
print the information of testcase which is on failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1606] print the information of testcase...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1606] print the information of testcase...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1189#issuecomment-193287545
+1 good catch. I was wondering why it seemed to work on the clojure code but not on junit. Thanks for doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1606] print the information of testcase...
Posted by unsleepy22 <gi...@git.apache.org>.
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/1189#issuecomment-192884522
Sorry, I didn't take a deep look. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1606] print the information of testcase...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/1189#discussion_r55138526
--- Diff: dev-tools/travis/print-errors-from-test-reports.py ---
@@ -55,6 +55,10 @@ def print_error_reports_from_report_file(file_path):
if fail is not None:
print_detail_information(testcase, fail)
+ failure = testcase.find("failure")
--- End diff --
@unsleepy22 the api "find(match)" of Python ElementTree finds the first sub element matching match. So the match is sub element, but not sub string
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1606] print the information of testcase...
Posted by unsleepy22 <gi...@git.apache.org>.
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1189#discussion_r55135284
--- Diff: dev-tools/travis/print-errors-from-test-reports.py ---
@@ -55,6 +55,10 @@ def print_error_reports_from_report_file(file_path):
if fail is not None:
print_detail_information(testcase, fail)
+ failure = testcase.find("failure")
--- End diff --
I would suspect the validity of this change since "fail" is a substring of "failure", the script should not miss "failure"s by searching "fail".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---