You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/22 08:13:37 UTC
Re: Review Request 43817: Removed no-longer-used model functions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 7:13 a.m.)
Review request for mesos and Michael Park.
Summary (updated)
-----------------
Removed no-longer-used model functions.
Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731
Repository: mesos
Description (updated)
-------
These `model()` variants provided functionality that is now
implemented via jsonify; no more call-sites of the old functions
remain.
Diffs (updated)
-----
src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
Diff: https://reviews.apache.org/r/43817/diff/
Testing
-------
make check
Also updated a few comments to not refer to `summarize`.
Thanks,
Neil Conway
Re: Review Request 43817: Removed no-longer-used model functions.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/#review120140
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43816, 43822, 43823, 43817]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 22, 2016, 7:13 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43817/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 7:13 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These `model()` variants provided functionality that is now
> implemented via jsonify; no more call-sites of the old functions
> remain.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
>
> Diff: https://reviews.apache.org/r/43817/diff/
>
>
> Testing
> -------
>
> make check
>
> Also updated a few comments to not refer to `summarize`.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43817: Removed no-longer-used model functions.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/#review121116
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 28, 2016, 12:17 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43817/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 12:17 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These `model()` variants provided functionality that is now
> implemented via jsonify; no more call-sites of the old functions
> remain.
>
>
> Diffs
> -----
>
> src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829
>
> Diff: https://reviews.apache.org/r/43817/diff/
>
>
> Testing
> -------
>
> make check
>
> Also updated a few comments to not refer to `summarize`.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43817: Removed no-longer-used model functions.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
-----------------------------------------------------------
(Updated Feb. 28, 2016, 12:17 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731
Repository: mesos
Description
-------
These `model()` variants provided functionality that is now
implemented via jsonify; no more call-sites of the old functions
remain.
Diffs (updated)
-----
src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829
Diff: https://reviews.apache.org/r/43817/diff/
Testing
-------
make check
Also updated a few comments to not refer to `summarize`.
Thanks,
Neil Conway
Re: Review Request 43817: Removed no-longer-used model functions.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 10:29 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731
Repository: mesos
Description
-------
These `model()` variants provided functionality that is now
implemented via jsonify; no more call-sites of the old functions
remain.
Diffs (updated)
-----
src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b
Diff: https://reviews.apache.org/r/43817/diff/
Testing
-------
make check
Also updated a few comments to not refer to `summarize`.
Thanks,
Neil Conway
Re: Review Request 43817: Removed no-longer-used model functions.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/#review120293
-----------------------------------------------------------
Ship it!
Ship It!
- Klaus Ma
On Feb. 22, 2016, 3:13 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43817/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 3:13 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These `model()` variants provided functionality that is now
> implemented via jsonify; no more call-sites of the old functions
> remain.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
>
> Diff: https://reviews.apache.org/r/43817/diff/
>
>
> Testing
> -------
>
> make check
>
> Also updated a few comments to not refer to `summarize`.
>
>
> Thanks,
>
> Neil Conway
>
>