You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wankai123 (via GitHub)" <gi...@apache.org> on 2025/03/10 02:13:35 UTC
[PR] Add more model installation log info for OAP storage initialization. [skywalking]
wankai123 opened a new pull request, #13094:
URL: https://github.com/apache/skywalking/pull/13094
- [X] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #13078.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more model installation log info for OAP storage initialization. [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #13094:
URL: https://github.com/apache/skywalking/pull/13094#discussion_r1986516969
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -559,4 +573,36 @@ private void checkTopNAggregation(Model model, BanyanDBClient client) throws Ban
}
}
}
+
+ @Getter
+ @Setter
+ private static class InstallInfoBanyanDB extends InstallInfo {
+ private DownSampling downSampling;
+ private String tableName;
+ private MetadataRegistry.Kind kind;
+ private String group;
+ private boolean tableExist;
+ private boolean groupExist;
+
+ protected InstallInfoBanyanDB(Model model) {
+ super(model);
+ }
+
+ @Override
+ public String buildInstallInfoMsg() {
+ return "InstallInfoBanyanDB{" +
+ "modelName=" + getModelName() +
+ ", modelType=" + getModelType() +
+ ", timeSeries=" + isTimeSeries() +
+ ", superDataset=" + isSuperDataset() +
+ ", downSampling=" + downSampling.name() +
+ ", tableName=" + tableName +
+ ", kind=" + kind.name() +
+ ", group=" + group +
+ ", allResourcesExist=" + isAllExist() +
+ " [groupExist=" + groupExist +
+ ", tableExist=" + tableExist +
+ "]}";
+ }
Review Comment:
Why not just use `toString` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more model installation log info for OAP storage initialization. [skywalking]
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #13094:
URL: https://github.com/apache/skywalking/pull/13094#discussion_r1986521903
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -559,4 +573,36 @@ private void checkTopNAggregation(Model model, BanyanDBClient client) throws Ban
}
}
}
+
+ @Getter
+ @Setter
+ private static class InstallInfoBanyanDB extends InstallInfo {
+ private DownSampling downSampling;
+ private String tableName;
+ private MetadataRegistry.Kind kind;
+ private String group;
+ private boolean tableExist;
+ private boolean groupExist;
+
+ protected InstallInfoBanyanDB(Model model) {
+ super(model);
+ }
+
+ @Override
+ public String buildInstallInfoMsg() {
+ return "InstallInfoBanyanDB{" +
+ "modelName=" + getModelName() +
+ ", modelType=" + getModelType() +
+ ", timeSeries=" + isTimeSeries() +
+ ", superDataset=" + isSuperDataset() +
+ ", downSampling=" + downSampling.name() +
+ ", tableName=" + tableName +
+ ", kind=" + kind.name() +
+ ", group=" + group +
+ ", allResourcesExist=" + isAllExist() +
+ " [groupExist=" + groupExist +
+ ", tableExist=" + tableExist +
+ "]}";
+ }
Review Comment:
I want to avoid the subclass forgetting to override the `toString` since it has a default implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more model installation log info for OAP storage initialization. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #13094:
URL: https://github.com/apache/skywalking/pull/13094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org