You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/01 10:21:21 UTC
[GitHub] [calcite] danny0405 opened a new pull request #2052: [CALCITE-4077] Exception when joined with built-in table functions
danny0405 opened a new pull request #2052:
URL: https://github.com/apache/calcite/pull/2052
The scope of SqlWindowTableFunction is special because all its operands
(except the first) should have the fucntion's first operand's scope, the
first operand is always an explicit table reference.
While this is not the perfect solution, the more proper way is to
refactor the CURSOR constructor, and always uses its queries scope. The
current CURSOR has some problems:
* It always has a type with name SqlTypeName#CURSOR, in the table
function senario, it is hard to do a auxiliary fields type infernece;
* It finally translates as a invocation with format "cast($0): CURSOR", the '$0' means
the first input, which is a wrong translation;
* It does not belong to the SQL standard.
A 'TABLE' constructor may be a good substitution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zinking commented on pull request #2052: [CALCITE-4077] Exception when joined with built-in table functions
Posted by GitBox <gi...@apache.org>.
zinking commented on pull request #2052:
URL: https://github.com/apache/calcite/pull/2052#issuecomment-652380194
LGTM, +1 for those details in documentations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 merged pull request #2052: [CALCITE-4077] Exception when joined with built-in table functions
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #2052:
URL: https://github.com/apache/calcite/pull/2052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] amaliujia commented on pull request #2052: [CALCITE-4077] Exception when joined with built-in table functions
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #2052:
URL: https://github.com/apache/calcite/pull/2052#issuecomment-652776214
+1 thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org