You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/01/06 08:41:11 UTC
[GitHub] [incubator-doris] Wsyzxxn opened a new pull request #2667:
java.lang.ClassCastException
Wsyzxxn opened a new pull request #2667: java.lang.ClassCastException
URL: https://github.com/apache/incubator-doris/pull/2667
fix org.apache.doris.analysis.CreateIndexClause cannot be cast to org.apache.doris.analysis.AlterTableClause
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2667:
java.lang.ClassCastException
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2667: java.lang.ClassCastException
URL: https://github.com/apache/incubator-doris/pull/2667#discussion_r363201277
##########
File path: fe/src/main/java/org/apache/doris/analysis/CreateIndexClause.java
##########
@@ -39,6 +39,7 @@ public CreateIndexClause(TableName tableName, IndexDef indexDef, boolean alter)
this.tableName = tableName;
this.indexDef = indexDef;
this.alter = alter;
+ this.needTableStable = false;
Review comment:
should be true when creating index
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #2667:
java.lang.ClassCastException
Posted by GitBox <gi...@apache.org>.
imay merged pull request #2667: java.lang.ClassCastException
URL: https://github.com/apache/incubator-doris/pull/2667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2667:
java.lang.ClassCastException
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2667: java.lang.ClassCastException
URL: https://github.com/apache/incubator-doris/pull/2667#discussion_r363204547
##########
File path: fe/src/main/java/org/apache/doris/analysis/CreateIndexClause.java
##########
@@ -24,7 +24,7 @@
import java.util.Map;
-public class CreateIndexClause extends AlterClause {
+public class CreateIndexClause extends AlterTableClause {
Review comment:
Can you fix DropIndexCluase together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org