You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/08 01:52:42 UTC
[GitHub] [pulsar] rdhabalia opened a new pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
rdhabalia opened a new pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158
### Motivation
Right now, if namespace is not configured with persistence policy then broker considers default persistence-policy while serving the topic but it returns null value in get-persistence admin API
```
./pulsar-admin namespaces get-persistence pulsar/standalone/ns2
null
```
### Modification
Return default persistence policy if namespace persistence policy is not configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158#issuecomment-1032730928
> I think we can add an `applied` to control whether we should return namespace setting or the value that actually take effects, like many other polices in `org.apache.pulsar.broker.admin.v2.PersistentTopics`
Agree, with this change, users will not able to know what is the namespace settings. We should apply the same behavior, for policies, if the topic/namespace don't have a policy, just provide a response to tell users no policy for this topic/namespace, if users want to check which policy will be applied, they can add --applied`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158#issuecomment-1032731468
I will move this one to milestone 2.11 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158#issuecomment-1032130237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158#issuecomment-1034379353
> with this change, users will not able to know what is the namespace settings.
this is incorrect, this PR only sets default persistence policy if the value is not configured and right now it's returning null which is confusing for user. we don't need any additional control flag to show null value to user. and regrading other policies , that can be handled in separate PR and we don't want to mix everything in this one.
@codelipenghui this PR has minor change which doesn't break any change then why should we change the release for this PR and why can't we merge to 2.10 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli closed pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158#issuecomment-1072916831
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158#issuecomment-1072991280
Reopened to trigger CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158#issuecomment-1032307924
this change only impacts api-get call code-path and it will not change set-policy with default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #14158: [pulsar-broker] Fix: return non-null persistence policy for namespace
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14158:
URL: https://github.com/apache/pulsar/pull/14158#issuecomment-1035637925
On a note completely unrelated to the content of this PR, we're able to merge this PR without a test passing because it is not "required". I am working on fixing this by updating the `.asf.yaml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org