You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2019/04/23 16:17:51 UTC
[kudu-CR] Add recommendation about nscd to requirements
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13084
to review the following change.
Change subject: Add recommendation about nscd to requirements
......................................................................
Add recommendation about nscd to requirements
Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/13084/1
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Apr 2019 16:55:25 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13084/2/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/13084/2/docs/installation.adoc@55
PS2, Line 55: - Although not a strict requirement, it's highly recommended to use nscd to
> Maybe use similar language to the troubleshooting doc:
Done
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Apr 2019 16:53:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Apr 2019 18:00:23 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Apr 2019 02:29:21 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13084
to look at the new patch set (#3).
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
[docs] KUDU-2395 Add nscd to requirements
Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
---
M docs/installation.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/13084/3
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13084
to look at the new patch set (#4).
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
[docs] KUDU-2395 Add nscd to requirements
Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
---
M docs/installation.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/13084/4
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Apr 2019 20:33:10 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Apr 2019 01:58:53 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13084
to look at the new patch set (#2).
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
[docs] KUDU-2395 Add nscd to requirements
Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/13084/2
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
[docs] KUDU-2395 Add nscd to requirements
Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Reviewed-on: http://gerrit.cloudera.org:8080/13084
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/installation.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 3: Verified+1 Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13084/3/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/13084/3/docs/installation.adoc@55
PS3, Line 55: nscd
nit: surround with backticks for consistency with https://kudu.apache.org/docs/troubleshooting.html#slow_dns_nscd ?
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Apr 2019 17:32:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13084
to look at the new patch set (#5).
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
[docs] KUDU-2395 Add nscd to requirements
Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
---
M docs/installation.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/13084/5
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13084/3/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/13084/3/docs/installation.adoc@55
PS3, Line 55: `nsc
> nit: surround with backticks for consistency with https://kudu.apache.org/d
Done
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Apr 2019 20:29:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13084 )
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13084/2/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/13084/2/docs/installation.adoc@55
PS2, Line 55: - Although not a strict requirement, it's highly recommended to use nscd to
Maybe use similar language to the troubleshooting doc:
`to cache both DNS name resolution and static name resolution`
A link to that part of the documentation for more detail would be useful too.
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Apr 2019 16:34:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] KUDU-2395 Add nscd to requirements
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [docs] KUDU-2395 Add nscd to requirements
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iad4db28297c08739b048dc46e398f7ddca80df48
Gerrit-Change-Number: 13084
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)