You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/08/09 15:35:24 UTC

[GitHub] [hbase] taklwu commented on a change in pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

taklwu commented on a change in pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#discussion_r685300460



##########
File path: dev-support/hbase-personality.sh
##########
@@ -464,7 +465,8 @@ function shadedjars_rebuild
   # If we have HADOOP_PROFILE specified and we're on branch-2.x, pass along
   # the hadoop.profile system property. Ensures that Hadoop2 and Hadoop3
   # logic is not both activated within Maven.
-  if [[ -n "${HADOOP_PROFILE}" ]] && [[ "${PATCH_BRANCH}" =~ branch-2* ]] ; then
+    if [[ -n "${HADOOP_PROFILE}" ]] \

Review comment:
       nit: this lines seems to have two extra spaces before `if`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org