[GitHub] [spark] juliuszsompolski commented on a diff in pull request #41015: [CONNECT][DOC] Add information on how to regenerate proto for python client

["juliuszsompolski (via GitHub)" <gi...@apache.org>]

juliuszsompolski commented on code in PR #41015:
URL: https://github.com/apache/spark/pull/41015#discussion_r1182675151


##########
connector/connect/README.md:
##########
@@ -21,6 +21,17 @@ user experience across all languages. Please follow the below guidelines:
 
 Python-specific development guidelines are located in [python/docs/source/development/testing.rst](https://github.com/apache/spark/blob/master/python/docs/source/development/testing.rst) that is published at [Development tab](https://spark.apache.org/docs/latest/api/python/development/index.html) in PySpark documentation.
 

Review Comment:
   I think that folder is `rst` based and published to the web documentation and not markdown based, so I think README.md doesn't fit there.
   But I was surprised that the documentation there doesn't mention getting dependencies from `dev/requirements.txt`. But I'm not really familiar with python dev and these docs, maybe someone more familiar should have a better idea what would be the best place for it? @HyukjinKwon ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org