You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/03/17 07:53:49 UTC
[GitHub] [incubator-netbeans] matthiasblaesing commented on issue #1164: Place the internationalisation bundles from the 3rd donation in the A…
matthiasblaesing commented on issue #1164: Place the internationalisation bundles from the 3rd donation in the A…
URL: https://github.com/apache/incubator-netbeans/pull/1164#issuecomment-473626552
@junichi11 you are right, the license change is not correct and must not be committed (the files were not part of an oracle donation, but integrated from a 3rd party source).
@borisheithecker it needs to be established, that the files you want to be merged are all from a donation. Then the license change needs to be applied (again only on the donated files). This is easiest done by splitting it into two commits: commit 1) import the files commit 2) update the license headers. If you then provide some info how the contents can be compared with the donated files it would be great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists