You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/09/27 10:14:43 UTC
[GitHub] [incubator-linkis] binbinCheng opened a new pull request, #3546: [linkis-scheduler]module errorcode optimization and documentation
binbinCheng opened a new pull request, #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546
**[linkis-scheduler]module errorcode optimization and documentation**
Related issues: #3425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3546: [linkis-scheduler]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546#discussion_r981139567
##########
linkis-commons/linkis-scheduler/src/main/java/org/apache/linkis/scheduler/errorcode/LinkisSchedulerErrorCodeSummary.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.scheduler.errorcode;
+
+public enum LinkisSchedulerErrorCodeSummary {
+ THE_REQUEST_ENGINE_TIMES_OUT(
+ 11055,
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志).",
Review Comment:
观看->查看
THE_REQUEST_ENGINE_TIMES_OUT -> REQUEST_ENGINE_TIME_OUT
"The job request engine time out (任务请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以查看EngineConnManager对应的out和log日志).",
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3546: [linkis-scheduler]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546#issuecomment-1259327339
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3546](https://codecov.io/gh/apache/incubator-linkis/pull/3546?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77ccd98) into [dev-1.3.1](https://codecov.io/gh/apache/incubator-linkis/commit/df850bb83cef08284b25201c9fc3ec67a92b825e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df850bb) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## dev-1.3.1 #3546 +/- ##
===============================================
- Coverage 13.77% 13.76% -0.01%
- Complexity 1306 1307 +1
===============================================
Files 876 877 +1
Lines 33820 33850 +30
Branches 4914 4914
===============================================
+ Hits 4660 4661 +1
- Misses 28506 28536 +30
+ Partials 654 653 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ler/errorcode/LinkisSchedulerErrorCodeSummary.java](https://codecov.io/gh/apache/incubator-linkis/pull/3546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL3NjaGVkdWxlci9lcnJvcmNvZGUvTGlua2lzU2NoZWR1bGVyRXJyb3JDb2RlU3VtbWFyeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/linkis/scheduler/AbstractScheduler.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvQWJzdHJhY3RTY2hlZHVsZXIuc2NhbGE=) | `36.36% <0.00%> (ø)` | |
| [...e/linkis/scheduler/executer/AbstractExecutor.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvZXhlY3V0ZXIvQWJzdHJhY3RFeGVjdXRvci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/linkis/scheduler/queue/SchedulerEvent.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvU2NoZWR1bGVyRXZlbnQuc2NhbGE=) | `50.00% <0.00%> (ø)` | |
| [...cheduler/queue/fifoqueue/FIFOConsumerManager.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Db25zdW1lck1hbmFnZXIuc2NhbGE=) | `75.75% <0.00%> (ø)` | |
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `38.67% <0.00%> (+1.88%)` | :arrow_up: |
| [...r/engineplugin/python/executor/PythonSession.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3546/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9weXRob24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vcHl0aG9uL2V4ZWN1dG9yL1B5dGhvblNlc3Npb24uc2NhbGE=) | `58.41% <0.00%> (-0.50%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #3546: [linkis-scheduler]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone merged PR #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3546: [linkis-scheduler]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546#discussion_r981156894
##########
linkis-commons/linkis-scheduler/src/main/java/org/apache/linkis/scheduler/errorcode/LinkisSchedulerErrorCodeSummary.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.scheduler.errorcode;
+
+public enum LinkisSchedulerErrorCodeSummary {
+ THE_REQUEST_ENGINE_TIMES_OUT(
+ 11055,
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志).",
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志)."),
+ TASK_STATUS_FLIP_STATE(
+ 12000,
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)",
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)"),
+ THE_SUNMISSION_IS_FULL(
+ 12001,
+ "The submission job failed and the queue is full!(提交作业失败，队列已满！)",
+ "The submission job failed and the queue is full!(提交作业失败，队列已满！)"),
+ UNRECOGNIZED_EXECID(
+ 12011, "Unrecognized execId (不能识别的execId):", "Unrecognized execId (不能识别的execId):"),
+ NEED_A_SUPPORTED(
+ 13000,
+ "FIFOConsumerManager need a FIFOGroup, but {} is supported.(FIFOConsumerManager 需要一个 FIFOGroup，但支持 {}.)",
+ "FIFOConsumerManager need a FIFOGroup, but {} is supported.(FIFOConsumerManager 需要一个 FIFOGroup，但支持 {}.)"),
+ IS_IN_STATE(20001, "{} is in state {}. ({} 处于状态 {}.)", "{} is in state {}. ({} 处于状态 {}.)");
Review Comment:
"FIFOConsumerManager just support FIFO group, {} is not FIFO group.(FIFOConsumerManager只支持FIFO类型的消费组，{} 不是这类消费组.)"),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3546: [linkis-scheduler]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546#discussion_r981150708
##########
linkis-commons/linkis-scheduler/src/main/java/org/apache/linkis/scheduler/errorcode/LinkisSchedulerErrorCodeSummary.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.scheduler.errorcode;
+
+public enum LinkisSchedulerErrorCodeSummary {
+ THE_REQUEST_ENGINE_TIMES_OUT(
+ 11055,
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志).",
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志)."),
+ TASK_STATUS_FLIP_STATE(
+ 12000,
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)",
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)"),
+ THE_SUNMISSION_IS_FULL(
+ 12001,
+ "The submission job failed and the queue is full!(提交作业失败，队列已满！)",
+ "The submission job failed and the queue is full!(提交作业失败，队列已满！)"),
+ UNRECOGNIZED_EXECID(
+ 12011, "Unrecognized execId (不能识别的execId):", "Unrecognized execId (不能识别的execId):"),
+ NEED_A_SUPPORTED(
+ 13000,
Review Comment:
NEED_SUPPORTTED_GROUP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3546: [linkis-scheduler]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546#discussion_r981148859
##########
linkis-commons/linkis-scheduler/src/main/java/org/apache/linkis/scheduler/errorcode/LinkisSchedulerErrorCodeSummary.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.scheduler.errorcode;
+
+public enum LinkisSchedulerErrorCodeSummary {
+ THE_REQUEST_ENGINE_TIMES_OUT(
+ 11055,
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志).",
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志)."),
+ TASK_STATUS_FLIP_STATE(
+ 12000,
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)",
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)"),
+ THE_SUNMISSION_IS_FULL(
Review Comment:
JOB_QUEUE_IS_FULL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3546: [linkis-scheduler]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546#discussion_r981156894
##########
linkis-commons/linkis-scheduler/src/main/java/org/apache/linkis/scheduler/errorcode/LinkisSchedulerErrorCodeSummary.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.scheduler.errorcode;
+
+public enum LinkisSchedulerErrorCodeSummary {
+ THE_REQUEST_ENGINE_TIMES_OUT(
+ 11055,
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志).",
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志)."),
+ TASK_STATUS_FLIP_STATE(
+ 12000,
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)",
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)"),
+ THE_SUNMISSION_IS_FULL(
+ 12001,
+ "The submission job failed and the queue is full!(提交作业失败，队列已满！)",
+ "The submission job failed and the queue is full!(提交作业失败，队列已满！)"),
+ UNRECOGNIZED_EXECID(
+ 12011, "Unrecognized execId (不能识别的execId):", "Unrecognized execId (不能识别的execId):"),
+ NEED_A_SUPPORTED(
+ 13000,
+ "FIFOConsumerManager need a FIFOGroup, but {} is supported.(FIFOConsumerManager 需要一个 FIFOGroup，但支持 {}.)",
+ "FIFOConsumerManager need a FIFOGroup, but {} is supported.(FIFOConsumerManager 需要一个 FIFOGroup，但支持 {}.)"),
+ IS_IN_STATE(20001, "{} is in state {}. ({} 处于状态 {}.)", "{} is in state {}. ({} 处于状态 {}.)");
Review Comment:
"FIFOConsumerManager just support FIFO group, {} is not FIFO group.(FIFOConsumerManager只支持FIFO类型的消费组，{} 不是这类消费组.)"),
NODE_STATE_ERROR(20001, "{} is in state {}. ({} 处于状态 {}.)", "节点状态不符合预期");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3546: [linkis-scheduler]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3546:
URL: https://github.com/apache/incubator-linkis/pull/3546#discussion_r981145753
##########
linkis-commons/linkis-scheduler/src/main/java/org/apache/linkis/scheduler/errorcode/LinkisSchedulerErrorCodeSummary.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.scheduler.errorcode;
+
+public enum LinkisSchedulerErrorCodeSummary {
+ THE_REQUEST_ENGINE_TIMES_OUT(
+ 11055,
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志).",
+ "The request engine times out (请求引擎超时，可能是EngineConnManager 启动EngineConn失败导致，可以去观看EngineConnManager的linkis.out和linkis.log日志)."),
+ TASK_STATUS_FLIP_STATE(
+ 12000,
+ "Task status flip error! Cause: Failed to flip from {} to $state.(任务状态翻转出错！原因：不允许从{} 翻转为{}.)",
Review Comment:
to $state -> to { }
TASK_STATUS_FLIP_ERROR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org