Re: [PATCH] Set application name once in gnome keyring

[Senthil Kumaran S <se...@collab.net>]

Hi Lieven,

Lieven Govaerts wrote:
> Senthil Kumaran S wrote:
>> <snip>
>> GLib-WARNING **: g_set_application() name called multiple times
>> </snip>
> This looks like a local fix to a non-local problem. Why is svnsync
> calling gnome_keyring_init multiple times?

After a bit of analysis, I came with this conclusion. Inside the svnsync code 
we call the following:

<snip>
   err = svn_cmdline_setup_auth_baton(&opt_baton.source_auth_baton,
                                      opt_baton.non_interactive,
                                      opt_baton.source_username,
                                      opt_baton.source_password,
                                      opt_baton.config_dir,
                                      opt_baton.no_auth_cache,
                                      config,
                                      check_cancel, NULL,
                                      pool);
   if (! err)
     err = svn_cmdline_setup_auth_baton(&opt_baton.sync_auth_baton,
                                        opt_baton.non_interactive,
                                        opt_baton.sync_username,
                                        opt_baton.sync_password,
                                        opt_baton.config_dir,
                                        opt_baton.no_auth_cache,
                                        config,
                                        check_cancel, NULL,
                                        pool);
</snip>

The above code sets up the auth baton for source and the sync repositories. 
When this piece of code is called one after the other, we inturn call 
gnome_init() function repeatedly, which tries to set the application name more 
than once without a check whether the application name was already set, inturn 
resulting in a warning.

-- 
Senthil Kumaran S
http://www.stylesen.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org