You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/07/06 14:19:23 UTC
Review Request 36196: Ambari Upgrade: configs are changing HDFS props
from final
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36196/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-12289
https://issues.apache.org/jira/browse/AMBARI-12289
Repository: ambari
Description
-------
1) Ambari 1.7 + HDP 2.1
2) Upgrade to Ambari 2.1, didn't touch stack
3) The following configuration changes should not have been changed. They seem unnecessary and we need to avoid making config changes if possible.
dfs.namenode.http-address, dfs.support.append and fs.defaultFS values were not changed, just switched from final to not final.
We should not be reverting the final unless we really need to.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 8c7f831
Diff: https://reviews.apache.org/r/36196/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 36196: Ambari Upgrade: configs are changing HDFS
props from final
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36196/#review90470
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On July 6, 2015, 12:19 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36196/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 12:19 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-12289
> https://issues.apache.org/jira/browse/AMBARI-12289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Ambari 1.7 + HDP 2.1
> 2) Upgrade to Ambari 2.1, didn't touch stack
> 3) The following configuration changes should not have been changed. They seem unnecessary and we need to avoid making config changes if possible.
> dfs.namenode.http-address, dfs.support.append and fs.defaultFS values were not changed, just switched from final to not final.
> We should not be reverting the final unless we really need to.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 8c7f831
>
> Diff: https://reviews.apache.org/r/36196/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>