[GitHub] sijie commented on issue #804: OrderedSafeExecutor exposes shaded guava API ListenableFuture

[GitBox <gi...@apache.org>]

sijie commented on issue #804: OrderedSafeExecutor exposes shaded guava API ListenableFuture
URL: https://github.com/apache/bookkeeper/issues/804#issuecomment-349061189
 
 
   It is a non-public or limited private API. The problem seems to appear when using a shaded jar, no? If you are using a non-shaded jar, I don't think the issue would appear.
   
   Given it is non-public api and only related a shaded jar, I am not sure if there is a strong need to switch to CompletableFuture, because the underlying executors are `ListeningScheduledExecutorService`. My take on this: 1) we can simply fix the shading rule, by changing 'bk-shade' to 'bkshade', to make it compiled with java 9; 2) defer changing it to `CompletableFuture` when they are needed.  BTW, personally I don't think this should be labelled as `important`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services