You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/04/12 12:23:03 UTC
[GitHub] sjanc commented on a change in pull request #894: console: Add
asynchronous RX handling for UART
sjanc commented on a change in pull request #894: console: Add asynchronous RX handling for UART
URL: https://github.com/apache/mynewt-core/pull/894#discussion_r181061015
##########
File path: sys/console/full/src/uart_console.c
##########
@@ -32,11 +32,17 @@
static struct uart_dev *uart_dev;
static struct console_ring cr_tx;
-/* must be after console_ring */
static uint8_t cr_tx_buf[MYNEWT_VAL(CONSOLE_UART_TX_BUF_SIZE)];
typedef void (*console_write_char)(struct uart_dev*, uint8_t);
static console_write_char write_char_cb;
+#if MYNEWT_VAL(CONSOLE_UART_RX_BUF_SIZE) > 0
+static struct console_ring cr_rx;
+static uint8_t cr_rx_buf[MYNEWT_VAL(CONSOLE_UART_RX_BUF_SIZE)];
+
+struct os_event rx_ev;
Review comment:
could be static
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services