[GitHub] [hbase] Apache9 commented on a change in pull request #330: HBASE-22617 Recovered WAL directories not getting cleaned up

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #330: HBASE-22617 Recovered WAL directories not getting cleaned up
URL: https://github.com/apache/hbase/pull/330#discussion_r296556832
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java
 ##########
 @@ -348,6 +347,13 @@ protected static void deleteFromFs(final MasterProcedureEnv env,
         throw new IOException("Couldn't delete mob dir " + mobTableDir);
       }
     }
+
+    // Delete the directory on wal filesystem
+    FileSystem walFs = mfs.getWALFileSystem();
+    Path tableWALDir = FSUtils.getWALTableDir(env.getMasterConfiguration(), tableName);
 
 Review comment:
   They could be on different file system. The table data are on the normal file system and these are on the wal file system. By default they are the same but they could be different, i.e, when deploying HBase on S3.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services