[jira] [Commented] (HDFS-8834) TestReplication#testReplicationWhenBlockCorruption is not valid after HDFS-6482

["Yi Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645391#comment-14645391 ] 

Yi Liu commented on HDFS-8834:
------------------------------

+1, pending Jenkins, thanks Lei.

> TestReplication#testReplicationWhenBlockCorruption is not valid after HDFS-6482
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-8834
>                 URL: https://issues.apache.org/jira/browse/HDFS-8834
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: datanode
>    Affects Versions: 2.7.1
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>              Labels: testing
>         Attachments: HDFS-8834.00.patch
>
>
> {{TestReplication#testReplicationWhenBlockCorruption}} assumes DN has one level of directory:
> {code}
> File[] listFiles = participatedNodeDirs.listFiles();
> {code}
> However, HDFS-6482 changed the layout of block directories and used two level directories, which makes the following code invalidate (not running).
> {code}
> for (File file : listFiles) {
>   if (file.getName().startsWith(Block.BLOCK_FILE_PREFIX)
>       && !file.getName().endsWith("meta")) {
>       blockFile = file.getName();
>       for (File file1 : nonParticipatedNodeDirs) {
>         file1.mkdirs();
>         new File(file1, blockFile).createNewFile();
>         new File(file1, blockFile + "_1000.meta").createNewFile();
>       }
>     break;
>     }
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)