You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2014/07/27 00:36:05 UTC

[GitHub] spark pull request: [SPARK-2601] [PySpark] Fix Py4J error when tra...

GitHub user JoshRosen opened a pull request:

    https://github.com/apache/spark/pull/1605

    [SPARK-2601] [PySpark] Fix Py4J error when transforming pickleFiles

    Similar to SPARK-1034, the problem was that Py4J didn’t cope well with the fake ClassTags used in the Java API.  It doesn’t look like there’s any reason why PythonRDD needs to take a ClassTag, since it just ignores the type of the previous RDD, so I removed the type parameter and we no longer pass ClassTags from Python.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JoshRosen/spark spark-2601

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1605.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1605
    
----
commit b68e118ad1cf5237a3e63a146fdc55ac8c7d59cf
Author: Josh Rosen <jo...@apache.org>
Date:   2014-07-26T22:31:03Z

    Fix Py4J error when transforming pickleFiles [SPARK-2601]
    
    Similar to SPARK-1034, the problem was that Py4J didn’t cope well with
    the fake ClassTags used in the Java API.  It doesn’t look like there’s
    any reason why PythonRDD needs to take a ClassTag, since it just ignores
    the type of the previous RDD, so I removed the type parameter and we
    no longer need to pass ClassTags from Python.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2601] [PySpark] Fix Py4J error when tra...

Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/1605#issuecomment-50252365
  
    Thanks Josh; merged this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2601] [PySpark] Fix Py4J error when tra...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/1605


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2601] [PySpark] Fix Py4J error when tra...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/1605#issuecomment-50250570
  
    QA tests have started for PR 1605. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17231/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2601] [PySpark] Fix Py4J error when tra...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/1605#issuecomment-50251333
  
    QA results for PR 1605:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17231/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---