[GitHub] [flink] vtkhanh commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…

["vtkhanh (via GitHub)" <gi...@apache.org>]

vtkhanh commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1148124903


##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
     public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
         if (validator.test(err)) {
             throwableConsumer.accept(throwableMapper.apply(err));
+            return true;
+        } else {

Review Comment:
   Dont think we should return `false` right after validator.test is `false` as it wont go into `chainedClassifier` check. Instead, we should return false at the line 55.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org