You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/10 07:58:11 UTC

[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4768: [Improvement-3369][api] Introduce taskrecord, udffunc, workflowlineage and workergroup service interface for clear code

codecov-io commented on pull request #4768:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4768#issuecomment-776518206


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768?src=pr&el=h1) Report
   > Merging [#4768](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768?src=pr&el=desc) (79210cc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/c9972936d6457505849dea96e3c4a2e056d8dd85?el=desc) (c997293) will **decrease** coverage by `0.01%`.
   > The diff coverage is `75.40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #4768      +/-   ##
   ============================================
   - Coverage     45.29%   45.28%   -0.02%     
   + Complexity     3393     3392       -1     
   ============================================
     Files           537      537              
     Lines         23076    23076              
     Branches       2687     2687              
   ============================================
   - Hits          10452    10449       -3     
   - Misses        11692    11693       +1     
   - Partials        932      934       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...eduler/api/service/impl/TaskRecordServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9UYXNrUmVjb3JkU2VydmljZUltcGwuamF2YQ==) | `4.76% <4.76%> (ø)` | `1.00 <1.00> (?)` | |
   | [...r/api/service/impl/WorkFlowLineageServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Xb3JrRmxvd0xpbmVhZ2VTZXJ2aWNlSW1wbC5qYXZh) | `78.26% <78.26%> (ø)` | `9.00 <9.00> (?)` | |
   | [...duler/api/service/impl/WorkerGroupServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Xb3JrZXJHcm91cFNlcnZpY2VJbXBsLmphdmE=) | `80.00% <80.00%> (ø)` | `9.00 <9.00> (?)` | |
   | [...scheduler/api/service/impl/UdfFuncServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9VZGZGdW5jU2VydmljZUltcGwuamF2YQ==) | `84.82% <84.82%> (ø)` | `19.00 <19.00> (?)` | |
   | [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `66.66% <0.00%> (-5.56%)` | `8.00% <0.00%> (-1.00%)` | |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768?src=pr&el=footer). Last update [c997293...79210cc](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4768?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org