You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by eiri <gi...@git.apache.org> on 2016/03/11 19:51:12 UTC
[GitHub] couchdb pull request: Update deps for chttpd and couch app
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb/pull/390
Update deps for chttpd and couch app
This points to the head of both couch-chttpd and couchdb-couch repos to make travis passable for new commits, as tests of the both repos depends on been in sync after CORS refactoring.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb update-chttpd-couch-deps
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit 46e932f82f871c63860f7ee6ddd5f10ccc2f9121
Author: Eric Avdey <ei...@eiri.ca>
Date: 2016-03-11T18:46:21Z
Update deps for chttpd and couch app
This points to the head of both couch-chttpd and couchdb-couch repos
to make travis passable for new commits, as tests of the both repos
depends on been in sync after CORS refactoring.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update deps for chttpd and couch app
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb/pull/390#issuecomment-195502255
Hm. chttpd is seven commits behind, same for couchdb-couch. That makes 3 "features" on couch and 2 on chttpd, as I eyeball git logs. Do you really want 5 separate PRs, consider that this one just became travis green? I mean I can do it, just asking if this is necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update deps for chttpd and couch app
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/390#issuecomment-195496807
I would do incremental update one commit per feature. This will simplify searches if something went wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update deps for chttpd and couch app
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/390#issuecomment-195505914
No, actually here we have two features: one CORS that updates both couch and chttpd, one fix EPI on chttpd. One PR with two commits is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update deps for chttpd and couch app
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb/pull/390#issuecomment-195528574
Good catch. We sure need something more reliable than wetware to handle this stuff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update deps for chttpd and couch app
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb/pull/390#issuecomment-195525355
Well, not two, but three, but who's counting, who's counting... ;)
Here we go - one commit per feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update deps for chttpd and couch app
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/390#issuecomment-195526652
Oh, wait, could you include "da860981c9718ba3a119236edcb01d1b4ad85d65" for replicator in " Remove configurable replicator db name"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update deps for chttpd and couch app
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update deps for chttpd and couch app
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/390#issuecomment-195525555
Oh, I didn't check what previous merge contained. Thanks! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---