[GitHub] wujimin commented on a change in pull request #451: [JAV-539] & [SCB-9] Implement CallCount and TPS Metrics

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #451: [JAV-539] & [SCB-9] Implement CallCount and TPS Metrics
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/451#discussion_r158592589
 
 

 ##########
 File path: metrics/metrics-core/src/main/java/io/servicecomb/metrics/core/event/InvocationStartProcessingEventListener.java
 ##########
 @@ -41,9 +41,14 @@ public InvocationStartProcessingEventListener(RegistryMonitor registryMonitor) {
   public void process(Event data) {
     InvocationStartProcessingEvent event = (InvocationStartProcessingEvent) data;
     InvocationMonitor monitor = registryMonitor.getInvocationMonitor(event.getOperationName());
+    //TODO:current java chassis unable know invocation type before starting process,so all type WaitInQueue increment(-1) (decrement)
 
 Review comment:
   why?
   event.getInvocationType is not you want?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services