You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mappjzc (via GitHub)" <gi...@apache.org> on 2023/03/30 11:31:37 UTC

[GitHub] [incubator-devlake] mappjzc commented on a diff in pull request #4804: Issues/4566 add tapd bp api

mappjzc commented on code in PR #4804:
URL: https://github.com/apache/incubator-devlake/pull/4804#discussion_r1153113474


##########
backend/plugins/tapd/models/workspace.go:
##########
@@ -18,27 +18,76 @@ limitations under the License.
 package models
 
 import (
+	"fmt"
 	"github.com/apache/incubator-devlake/core/models/common"
+	"github.com/apache/incubator-devlake/core/plugin"
 	helper "github.com/apache/incubator-devlake/helpers/pluginhelper/api"
 )
 
-type TapdWorkspace struct {
-	ConnectionId uint64          `gorm:"primaryKey;type:BIGINT  NOT NULL"`
-	Id           uint64          `gorm:"primaryKey;type:BIGINT" json:"id,string"`
-	Name         string          `gorm:"type:varchar(255)" json:"name"`
-	PrettyName   string          `gorm:"type:varchar(255)" json:"pretty_name"`
-	Category     string          `gorm:"type:varchar(255)" json:"category"`
-	Status       string          `gorm:"type:varchar(255)" json:"status"`
-	Description  string          `json:"description"`
-	BeginDate    *helper.CSTTime `json:"begin_date"`
-	EndDate      *helper.CSTTime `json:"end_date"`
-	ExternalOn   string          `gorm:"type:varchar(255)" json:"external_on"`
-	ParentId     uint64          `gorm:"type:BIGINT" json:"parent_id,string"`
-	Creator      string          `gorm:"type:varchar(255)" json:"creator"`
-	Created      *helper.CSTTime `json:"created"`
+type ApiTapdWorkspace struct {
+	ConnectionId         uint64          `gorm:"primaryKey;type:BIGINT  NOT NULL"`
+	Id                   uint64          `gorm:"primaryKey;type:BIGINT" json:"id,string"`
+	Name                 string          `gorm:"type:varchar(255)" json:"name"`
+	PrettyName           string          `gorm:"type:varchar(255)" json:"pretty_name"`
+	Category             string          `gorm:"type:varchar(255)" json:"category"`
+	Status               string          `gorm:"type:varchar(255)" json:"status"`
+	Description          string          `json:"description"`
+	BeginDate            *helper.CSTTime `json:"begin_date"`
+	EndDate              *helper.CSTTime `json:"end_date"`
+	ExternalOn           string          `gorm:"type:varchar(255)" json:"external_on"`
+	ParentId             uint64          `gorm:"type:BIGINT" json:"parent_id,string"`
+	Creator              string          `gorm:"type:varchar(255)" json:"creator"`
+	Created              *helper.CSTTime `json:"created"`
+	TransformationRuleId uint64          `json:"transformationRuleId,omitempty" mapstructure:"transformationRuleId"`

Review Comment:
   Why the ApiTapdWorkspace has TransformationRuleId and as same as TapdWorkspace?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org