You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2016/04/06 19:35:32 UTC
Review Request 45820: Minor clarity changes for Lucene dunit test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45820/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
Removed a system out that looks out of place
Renamed the test methods to hopefully fit better with the actual method
The test itself looks to only work for PartitionedRegions (the rebalance operation would fail for a replicated region?) and the destroy Region only works for a Partitioned Region at this point, but I didn't rename the e2eTextSearchForRegionType for now.
Diffs
-----
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java 901b363
Diff: https://reviews.apache.org/r/45820/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 45820: Minor clarity changes for Lucene dunit test
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45820/#review127400
-----------------------------------------------------------
Ship it!
Good to see you Ashvin :)
- Dan Smith
On April 6, 2016, 5:35 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45820/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:35 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Removed a system out that looks out of place
> Renamed the test methods to hopefully fit better with the actual method
>
> The test itself looks to only work for PartitionedRegions (the rebalance operation would fail for a replicated region?) and the destroy Region only works for a Partitioned Region at this point, but I didn't rename the e2eTextSearchForRegionType for now.
>
>
> Diffs
> -----
>
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java 901b363
>
> Diff: https://reviews.apache.org/r/45820/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 45820: Minor clarity changes for Lucene dunit test
Posted by Ashvin A <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45820/#review127385
-----------------------------------------------------------
Ship it!
Looks good to me
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java
<https://reviews.apache.org/r/45820/#comment190685>
My bad. Thanks for fixing this :-)
- Ashvin A
On April 6, 2016, 5:35 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45820/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:35 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Removed a system out that looks out of place
> Renamed the test methods to hopefully fit better with the actual method
>
> The test itself looks to only work for PartitionedRegions (the rebalance operation would fail for a replicated region?) and the destroy Region only works for a Partitioned Region at this point, but I didn't rename the e2eTextSearchForRegionType for now.
>
>
> Diffs
> -----
>
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java 901b363
>
> Diff: https://reviews.apache.org/r/45820/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>