You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/05/16 09:09:38 UTC
Review Request 47407: LENS-1140 : Fix loading jar in HDFS as a
session jar with db resources available.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47407/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1140
https://issues.apache.org/jira/browse/LENS-1140
Repository: lens
Description
-------
Changes include :
- Added uri and location field as separate fields in ResourceEntry - uri will be whats passed by user and location will have the final downloaded path.
- Load on db reosurces will load the downloaded path and not the uri.
- Newly downloaed location will be updated on server restarts
- Remove add and delete from BaseLensService and addResourceToAllServices in SessionService - as resources always get added only in session
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 81160f5
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee72
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b97
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c53
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f16
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a74c8cd
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b519426
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 692a0a0
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java 1008faf
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java de03da1
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 685ad85
Diff: https://reviews.apache.org/r/47407/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.444s]
[INFO] Lens .............................................. SUCCESS [3.583s]
[INFO] Lens API .......................................... SUCCESS [21.893s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.775s]
[INFO] Lens Cube ......................................... SUCCESS [15:24.877s]
[INFO] Lens DB storage ................................... SUCCESS [15.815s]
[INFO] Lens Query Library ................................ SUCCESS [12.781s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:23.224s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.389s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.362s]
[INFO] Lens Server ....................................... SUCCESS [8:33.810s]
[INFO] Lens client ....................................... SUCCESS [1:34.877s]
[INFO] Lens CLI .......................................... SUCCESS [1:27.371s]
[INFO] Lens Examples ..................................... SUCCESS [8.981s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.679s]
[INFO] Lens Distribution ................................. SUCCESS [9.657s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:11.456s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.260s]
[INFO] Lens Regression ................................... SUCCESS [10.429s]
[INFO] Lens UI ........................................... SUCCESS [27.584s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:44.105s
[INFO] Finished at: Mon May 16 08:59:08 UTC 2016
[INFO] Final Memory: 213M/2760M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 47407: LENS-1140 : Fix loading jar in HDFS as a
session jar with db resources available.
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47407/#review133681
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java (line 135)
<https://reviews.apache.org/r/47407/#comment198266>
Do we need to handle case where add_resource() returns null or a RunTime Exception is thrown ?
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 288)
<https://reviews.apache.org/r/47407/#comment198261>
Can we update finalLocation in comments also
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java (line 148)
<https://reviews.apache.org/r/47407/#comment198260>
By not catching the exception inside the loop, we will fail fast which seems correct. Just re-conforming.
- Puneet Gupta
On May 16, 2016, 9:09 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47407/
> -----------------------------------------------------------
>
> (Updated May 16, 2016, 9:09 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1140
> https://issues.apache.org/jira/browse/LENS-1140
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Added uri and location field as separate fields in ResourceEntry - uri will be whats passed by user and location will have the final downloaded path.
> - Load on db reosurces will load the downloaded path and not the uri.
> - Newly downloaed location will be updated on server restarts
> - Remove add and delete from BaseLensService and addResourceToAllServices in SessionService - as resources always get added only in session
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 81160f5
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee72
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b97
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c53
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f16
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a74c8cd
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b519426
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 692a0a0
> lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java 1008faf
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java de03da1
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 685ad85
>
> Diff: https://reviews.apache.org/r/47407/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.444s]
> [INFO] Lens .............................................. SUCCESS [3.583s]
> [INFO] Lens API .......................................... SUCCESS [21.893s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.775s]
> [INFO] Lens Cube ......................................... SUCCESS [15:24.877s]
> [INFO] Lens DB storage ................................... SUCCESS [15.815s]
> [INFO] Lens Query Library ................................ SUCCESS [12.781s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:23.224s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.389s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.362s]
> [INFO] Lens Server ....................................... SUCCESS [8:33.810s]
> [INFO] Lens client ....................................... SUCCESS [1:34.877s]
> [INFO] Lens CLI .......................................... SUCCESS [1:27.371s]
> [INFO] Lens Examples ..................................... SUCCESS [8.981s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.679s]
> [INFO] Lens Distribution ................................. SUCCESS [9.657s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:11.456s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.260s]
> [INFO] Lens Regression ................................... SUCCESS [10.429s]
> [INFO] Lens UI ........................................... SUCCESS [27.584s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:44.105s
> [INFO] Finished at: Mon May 16 08:59:08 UTC 2016
> [INFO] Final Memory: 213M/2760M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 47407: LENS-1140 : Fix loading jar in HDFS as a
session jar with db resources available.
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47407/#review133915
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On May 19, 2016, 5:15 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47407/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:15 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1140
> https://issues.apache.org/jira/browse/LENS-1140
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Added uri and location field as separate fields in ResourceEntry - uri will be whats passed by user and location will have the final downloaded path.
> - Load on db reosurces will load the downloaded path and not the uri.
> - Newly downloaed location will be updated on server restarts
> - Remove add and delete from BaseLensService and addResourceToAllServices in SessionService - as resources always get added only in session
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 81160f5
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee72
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b97
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c53
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f16
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a74c8cd
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b519426
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 797886d
> lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java 1008faf
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java de03da1
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 685ad85
>
> Diff: https://reviews.apache.org/r/47407/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.444s]
> [INFO] Lens .............................................. SUCCESS [3.583s]
> [INFO] Lens API .......................................... SUCCESS [21.893s]
> [INFO] Lens API for server and extensions ................ SUCCESS [15.775s]
> [INFO] Lens Cube ......................................... SUCCESS [15:24.877s]
> [INFO] Lens DB storage ................................... SUCCESS [15.815s]
> [INFO] Lens Query Library ................................ SUCCESS [12.781s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:23.224s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.389s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.362s]
> [INFO] Lens Server ....................................... SUCCESS [8:33.810s]
> [INFO] Lens client ....................................... SUCCESS [1:34.877s]
> [INFO] Lens CLI .......................................... SUCCESS [1:27.371s]
> [INFO] Lens Examples ..................................... SUCCESS [8.981s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.679s]
> [INFO] Lens Distribution ................................. SUCCESS [9.657s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:11.456s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.260s]
> [INFO] Lens Regression ................................... SUCCESS [10.429s]
> [INFO] Lens UI ........................................... SUCCESS [27.584s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:44.105s
> [INFO] Finished at: Mon May 16 08:59:08 UTC 2016
> [INFO] Final Memory: 213M/2760M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 47407: LENS-1140 : Fix loading jar in HDFS as a
session jar with db resources available.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47407/
-----------------------------------------------------------
(Updated May 19, 2016, 5:15 a.m.)
Review request for lens.
Changes
-------
Review comments fixed
Bugs: LENS-1140
https://issues.apache.org/jira/browse/LENS-1140
Repository: lens
Description
-------
Changes include :
- Added uri and location field as separate fields in ResourceEntry - uri will be whats passed by user and location will have the final downloaded path.
- Load on db reosurces will load the downloaded path and not the uri.
- Newly downloaed location will be updated on server restarts
- Remove add and delete from BaseLensService and addResourceToAllServices in SessionService - as resources always get added only in session
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 81160f5
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 9f8ee72
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c9f9b97
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c53
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 97d5f16
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 88406c5
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a74c8cd
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b519426
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 797886d
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java 1008faf
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java de03da1
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 685ad85
Diff: https://reviews.apache.org/r/47407/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.444s]
[INFO] Lens .............................................. SUCCESS [3.583s]
[INFO] Lens API .......................................... SUCCESS [21.893s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.775s]
[INFO] Lens Cube ......................................... SUCCESS [15:24.877s]
[INFO] Lens DB storage ................................... SUCCESS [15.815s]
[INFO] Lens Query Library ................................ SUCCESS [12.781s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:23.224s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.389s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.362s]
[INFO] Lens Server ....................................... SUCCESS [8:33.810s]
[INFO] Lens client ....................................... SUCCESS [1:34.877s]
[INFO] Lens CLI .......................................... SUCCESS [1:27.371s]
[INFO] Lens Examples ..................................... SUCCESS [8.981s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.679s]
[INFO] Lens Distribution ................................. SUCCESS [9.657s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:11.456s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.260s]
[INFO] Lens Regression ................................... SUCCESS [10.429s]
[INFO] Lens UI ........................................... SUCCESS [27.584s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:44.105s
[INFO] Finished at: Mon May 16 08:59:08 UTC 2016
[INFO] Final Memory: 213M/2760M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu