[jira] [Commented] (KAFKA-5483) Shutdown of scheduler should come after LogManager

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066603#comment-16066603 ] 

ASF GitHub Bot commented on KAFKA-5483:
---------------------------------------

GitHub user mimaison opened a pull request:

    https://github.com/apache/kafka/pull/3452

    KAFKA-5483: Shutdown of scheduler should come after LogManager

    Close the scheduler after all components using it have been shutdown
    
    @hachikuji Can you have a look ?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mimaison/kafka KAFKA-5483

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3452
    
----
commit 3481adaf02426e55639f6395c5ed9d49128a7d3a
Author: Mickael Maison <mi...@gmail.com>
Date:   2017-06-27T16:04:45Z

    KAFKA-5483: Shutdown of scheduler should come after LogManager
    
    Close the scheduler after all components using it have been shutdown

----


> Shutdown of scheduler should come after LogManager
> --------------------------------------------------
>
>                 Key: KAFKA-5483
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5483
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Mickael Maison
>
> It seems like we shutdown the scheduler used by LogManager before shutting down LogManager itself. This can lead to an IllegalStateException
> {code}
> "[2017-06-06 18:10:19,025] ERROR [ReplicaFetcherThread-14-111], Error due to  (kafka.server.ReplicaFetcherThread)
> kafka.common.KafkaException: error processing data for partition [akiraPricedProduct.global,10] offset 191893
>         at kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1$$anonfun$apply$2.apply(AbstractFetcherThread.scala:170)
>         at kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1$$anonfun$apply$2.apply(AbstractFetcherThread.scala:141)
>         at scala.Option.foreach(Option.scala:257)
>         at kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1.apply(AbstractFetcherThread.scala:141)
>         at kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1.apply(AbstractFetcherThread.scala:138)
>         at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
>         at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
>         at kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2.apply$mcV$sp(AbstractFetcherThread.scala:138)
>         at kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2.apply(AbstractFetcherThread.scala:138)
>         at kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2.apply(AbstractFetcherThread.scala:138)
>         at kafka.utils.CoreUtils$.inLock(CoreUtils.scala:234)
>         at kafka.server.AbstractFetcherThread.processFetchRequest(AbstractFetcherThread.scala:136)
>         at kafka.server.AbstractFetcherThread.doWork(AbstractFetcherThread.scala:103)
>         at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:63)
> Caused by: java.lang.IllegalStateException: Kafka scheduler is not running.
>         at kafka.utils.KafkaScheduler.ensureRunning(KafkaScheduler.scala:132)
>         at kafka.utils.KafkaScheduler.schedule(KafkaScheduler.scala:106)
>         at kafka.log.Log.roll(Log.scala:794)
>         at kafka.log.Log.maybeRoll(Log.scala:744)
>         at kafka.log.Log.append(Log.scala:405)
>         at kafka.server.ReplicaFetcherThread.processPartitionData(ReplicaFetcherThread.scala:130)
>         at kafka.server.ReplicaFetcherThread.processPartitionData(ReplicaFetcherThread.scala:42)
>         at kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1$$anonfun$apply$2.apply(AbstractFetcherThread.scala:153)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)