You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/18 16:15:43 UTC

Review Request 34355: Duplicate repo_suse_rhel.j2 templates

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34355/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-11214
    https://issues.apache.org/jira/browse/AMBARI-11214


Repository: ambari


Description
-------

We have two templates to create .repo files. Which one is used when (in cases
where users need to set enabled=0)? Can we eliminate one of them? Will need to
update docs for satellite setup based on this situation.

<https://github.com/apache/ambari/blob/trunk/ambari-
server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2>  
<https://github.com/apache/ambari/blob/trunk/ambari-
server/src/main/resources/stacks/HDP/2.0.6/hooks/before-
INSTALL/templates/repo_suse_rhel.j2>


Diffs
-----

  ambari-agent/src/test/python/resource_management/TestRepositoryResource.py c31cc20 
  ambari-common/src/main/python/resource_management/libraries/data/repo_suse_rhel.j2 PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/data/repo_ubuntu.j2 PRE-CREATION 
  ambari-common/src/main/python/resource_management/libraries/providers/repository.py 85ad83e 
  ambari-server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2 1cb687f 
  ambari-server/src/main/resources/custom_actions/templates/repo_ubuntu.j2 52d4c9a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_suse_rhel.j2 d486f89 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_ubuntu.j2 52d4c9a 

Diff: https://reviews.apache.org/r/34355/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 34355: Duplicate repo_suse_rhel.j2 templates

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34355/#review84150
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Травень 18, 2015, 2:15 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34355/
> -----------------------------------------------------------
> 
> (Updated Травень 18, 2015, 2:15 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11214
>     https://issues.apache.org/jira/browse/AMBARI-11214
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We have two templates to create .repo files. Which one is used when (in cases
> where users need to set enabled=0)? Can we eliminate one of them? Will need to
> update docs for satellite setup based on this situation.
> 
> <https://github.com/apache/ambari/blob/trunk/ambari-
> server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2>  
> <https://github.com/apache/ambari/blob/trunk/ambari-
> server/src/main/resources/stacks/HDP/2.0.6/hooks/before-
> INSTALL/templates/repo_suse_rhel.j2>
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py c31cc20 
>   ambari-common/src/main/python/resource_management/libraries/data/repo_suse_rhel.j2 PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/data/repo_ubuntu.j2 PRE-CREATION 
>   ambari-common/src/main/python/resource_management/libraries/providers/repository.py 85ad83e 
>   ambari-server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2 1cb687f 
>   ambari-server/src/main/resources/custom_actions/templates/repo_ubuntu.j2 52d4c9a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_suse_rhel.j2 d486f89 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_ubuntu.j2 52d4c9a 
> 
> Diff: https://reviews.apache.org/r/34355/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>