You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2025/10/25 07:46:57 UTC
[PR] Upgrade to opentelemetry-semconv 1.32.0 and opentelemetry-semconv-incubating and 1.32.0-alpha, maintain those versions separately [cxf]
ppalaga opened a new pull request, #2683:
URL: https://github.com/apache/cxf/pull/2683
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make forward-compatible with opentelemetry-semconv-incubating 1.32.0-alpha [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta merged PR #2683:
URL: https://github.com/apache/cxf/pull/2683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade to opentelemetry-semconv 1.32.0 and opentelemetry-semconv-incubating and 1.32.0-alpha, maintain those versions separately [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2683:
URL: https://github.com/apache/cxf/pull/2683#discussion_r2463123537
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -141,7 +141,7 @@ protected void stopTraceSpan(final TraceScopeHolder<TraceScope> holder, final Th
span.setStatus(StatusCode.ERROR);
if (ex != null) {
- span.recordException(ex, Attributes.of(ExceptionAttributes.EXCEPTION_ESCAPED, true));
+ span.recordException(ex);
Review Comment:
> Does CXF 4.2 have any ETA?
Yes, we hope to get it out of the door before end of the year (tentatively, for sure).
> Why do we rely on SNAPSHOT dependencies in a stable branch?
The branch is development mode, it is acceptable to have the SNAPSHOTs during the development cycle. We've just released `cxf-cxj-utils`, in preparation for release, should be all set now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade to opentelemetry-semconv 1.32.0 and opentelemetry-semconv-incubating and 1.32.0-alpha, maintain those versions separately [cxf]
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #2683:
URL: https://github.com/apache/cxf/pull/2683#discussion_r2462648631
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -141,7 +141,7 @@ protected void stopTraceSpan(final TraceScopeHolder<TraceScope> holder, final Th
span.setStatus(StatusCode.ERROR);
if (ex != null) {
- span.recordException(ex, Attributes.of(ExceptionAttributes.EXCEPTION_ESCAPED, true));
+ span.recordException(ex);
Review Comment:
`ExceptionAttributes.EXCEPTION_ESCAPED` was removed in opentelemetry-semconv-incubating 1.30.0-alpha. Its docs said since longer that it was deprecated and "It’s no longer recommended to record exceptions that are handled and do not escape the scope of a span.", so just removing the attribute, given the hardcoded `true`, should be fine - see https://opentelemetry.io/docs/specs/semconv/registry/attributes/exception/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade to opentelemetry-semconv 1.32.0 and opentelemetry-semconv-incubating and 1.32.0-alpha, maintain those versions separately [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2683:
URL: https://github.com/apache/cxf/pull/2683#discussion_r2462729513
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -141,7 +141,7 @@ protected void stopTraceSpan(final TraceScopeHolder<TraceScope> holder, final Th
span.setStatus(StatusCode.ERROR);
if (ex != null) {
- span.recordException(ex, Attributes.of(ExceptionAttributes.EXCEPTION_ESCAPED, true));
+ span.recordException(ex);
Review Comment:
Yes, we know about this change and it is planned for 4.2 (see please https://github.com/apache/cxf/pull/2473/files#diff-c7f236ca73be741018e92028d79517c03d1bbc27fe58a1b8dd4258bb4a80b38eL144). I think we could incorporate that into 4.0.x line as well but without bringing `1.32.0` (we broke a few downstream dependencies in the past), thanks @ppalaga
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -141,7 +141,7 @@ protected void stopTraceSpan(final TraceScopeHolder<TraceScope> holder, final Th
span.setStatus(StatusCode.ERROR);
if (ex != null) {
- span.recordException(ex, Attributes.of(ExceptionAttributes.EXCEPTION_ESCAPED, true));
+ span.recordException(ex);
Review Comment:
Yes, we know about this change and it is planned for 4.2 (see please https://github.com/apache/cxf/pull/2473/files#diff-c7f236ca73be741018e92028d79517c03d1bbc27fe58a1b8dd4258bb4a80b38eL144). I think we could incorporate that into 4.1.x line as well but without bringing `1.32.0` (we broke a few downstream dependencies in the past), thanks @ppalaga
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make forward-compatible with opentelemetry-semconv-incubating 1.32.0-alpha [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #2683:
URL: https://github.com/apache/cxf/pull/2683#issuecomment-3450756757
> It would be nice to get CXF 4.1.4 before Quarkus Quarkus 3.30.0 which I assume will get released in cca 3 weeks
Thanks @ppalaga , release is planned but we also are waiting for WSS4J release, expected to be out very soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade to opentelemetry-semconv 1.32.0 and opentelemetry-semconv-incubating and 1.32.0-alpha, maintain those versions separately [cxf]
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #2683:
URL: https://github.com/apache/cxf/pull/2683#discussion_r2463114001
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -141,7 +141,7 @@ protected void stopTraceSpan(final TraceScopeHolder<TraceScope> holder, final Th
span.setStatus(StatusCode.ERROR);
if (ex != null) {
- span.recordException(ex, Attributes.of(ExceptionAttributes.EXCEPTION_ESCAPED, true));
+ span.recordException(ex);
Review Comment:
Thanks for the details, @reta.
Does CXF 4.2 have any ETA?
> I think we could incorporate that into 4.1.x line as well but without bringing 1.32.0
Interesting idea. I will try next week whether it solves our problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make forward-compatible with opentelemetry-semconv-incubating 1.32.0-alpha [cxf]
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #2683:
URL: https://github.com/apache/cxf/pull/2683#issuecomment-3449954331
799256f:
* Does not upgrade opentelemetry-semconv-incubating
* Stops relying on `ExceptionAttributes.EXCEPTION_ESCAPED`.
Thanks for the tip, @reta, this also solves our problem on the upcoming Quarkus 3.30.0
It would be nice to get CXF 4.1.4 before Quarkus Quarkus 3.30.0 which I assume will get released in cca 3 weeks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade to opentelemetry-semconv 1.32.0 and opentelemetry-semconv-incubating and 1.32.0-alpha, maintain those versions separately [cxf]
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #2683:
URL: https://github.com/apache/cxf/pull/2683#issuecomment-3446128357
Hm... the CI fails with
```
Plugin org.apache.cxf.build-utils:cxf-xml2fastinfoset-plugin:4.1.2-SNAPSHOT or one of its dependencies could not be resolved:
Error: Could not find artifact org.apache.cxf.build-utils:cxf-xml2fastinfoset-plugin:jar:4.1.2-SNAPSHOT in apache.snapshots
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org